1449/filter no results #1476

ColinBuyck · 2022-10-20T21:51:14Z

Pull Request Template

Issue Overview

This PR addresses #1449

This change addresses the issue in full
This change addresses only certain aspects of the issue
This change is a dependency for another issue
This change has a dependency from another issue

Description

This PR adds a clearer UI when a user enters filters or finishes going through the listing finder and there are no rentals that match their selections.

How Can This Be Tested/Reviewed?

This can be tested by adding filters until there are no rentals that match. Ensure that the resulting page matches the Figma in the issue.

Checklist:

Reviewer Notes:

Steps to review a PR:

Read and understand the issue, and ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

netlify · 2022-10-20T21:51:18Z

✅ Deploy Preview for detroit-storybook-dev ready!

Name	Link
🔨 Latest commit	`994b794`
🔍 Latest deploy log	https://app.netlify.com/sites/detroit-storybook-dev/deploys/6357147a824e5d0008af9744
😎 Deploy Preview	https://deploy-preview-1476--detroit-storybook-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-10-20T21:51:21Z

✅ Deploy Preview for detroit-partners-dev ready!

Name	Link
🔨 Latest commit	`994b794`
🔍 Latest deploy log	https://app.netlify.com/sites/detroit-partners-dev/deploys/6357147a440657000807c44e
😎 Deploy Preview	https://deploy-preview-1476--detroit-partners-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-10-20T21:51:32Z

✅ Deploy Preview for detroit-public-dev ready!

Name	Link
🔨 Latest commit	`994b794`
🔍 Latest deploy log	https://app.netlify.com/sites/detroit-public-dev/deploys/6357147a5bf8f60008c0389b
😎 Deploy Preview	https://deploy-preview-1476--detroit-public-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ludtkemorgan · 2022-10-21T14:30:10Z

ui-components/src/locales/bn.json

@@ -1173,7 +1173,6 @@
  "listingFilters.waitlist": "প্রতীক্ষার তালিকা",
  "listingFilters.applyFilter": "ফিল্টার প্রয়োগ করুন",
  "listingFilters.noResults": "কোন ফলাফল নেই",
-  "listingFilters.noResultsSubtitle": "সেরা ফলাফলের জন্য ফিল্টার সম্পাদনা বা অপসারণ করুন।",


Are there no changes needed for Spanish?

@ludtkemorgan Turns out the Spanish translations were missing for that string 👀

ludtkemorgan · 2022-10-21T14:41:30Z

sites/public/styles/blocks.scss

+  .action-block__header {
+    font-size: var(--bloom-font-size-lg);
+  }
+  .action-block__icon {
+    margin-bottom: var(--bloom-s8);
+  }
+  .action-block__subheader {
+    padding-top: var(--bloom-s4);


I'm curious how important these CSS changes are. For the most part they aren't drastically changing the appearance of action block. Just slightly smaller header and larger spacing between the sections. Ideally we wouldn't want this custom of CSS if we don't have to. And if this is the standard spacing going forward we should think about updating the ActionBlock component instead so it gets applied everywhere.

That does increase the scope though and I'm fine with these changes if we believe this is needed and should be separate from the other ActionBlock usages.

One thing to consider though is it appears that the header for ActionBlock normally changes size depending on the width of the screen. Is that something we would want to persist for this use case?

@ludtkemorgan This all makes sense to me and I share your concerns on the custom CSS. It seems like this is a call for @slowbot. Do you think the customizations in the Figma are critical or should I stick to the general Action Block spacing? For comparison, the screenshot below is the Action Block without customizations.

@ColinBuyck @ludtkemorgan You can use styles as in in the current component CSS

adriencyberspace

LGTM!

* fix: wip action block * fix: custom block css * fix: matching spacing to figma * fix: removed custom styling

* build(deps): bump github/codeql-action from 1 to 2 (#1375) * fix: allow deletion of users * chore: standardize the typescript version (bloom-housing#3086) * feat: add neighborhood amenities to listing * fix: update activity-log relationship to users for deletion * fix: table columns should take up full width (bloom-housing#3005) * 1449/filter no results (#1476) * fix: wip action block * fix: custom block css * fix: matching spacing to figma * fix: removed custom styling * feat: add neighborhood amenities to partners (#1467) * feat: add neighborhood amenities input section * feat: add neighborhood amenities details section * feat: add details neighborhood amenities section * test: neighborhood amenities partners fields * feat: update neighborhood amenities subtitle * feat: move titles to partners folder * fix: switch listing to server side props (bloom-housing#3145) (#1484) * feat: add neighborhood amenities to public site (#1470) * feat: add neighborhood amenities to public listing description * feat: move amenities section into neighborhood on mobile * feat: add get directions link under the map * Listings Finder Feature Builder (#1453) * 1422/finder scaffolding + Q1 (#1448) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: mobile styling * fix: string + OnClick cleanup * 1434/listing finder q2 (#1452) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: pr cleanup * fix: typos + field value refactor * fix: auto-submit issue * 1443/listing finder disclaimer (#1461) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: remove unused div * fix: skip functionality + PR feedback * fix: refine react code * 1442/listing finder q3 (#1463) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div * 1444+5/listing finder q4+5 (#1472) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: remove empty div * fix: remove logs * fix: no results bug * fix: minor border issue * fix: disclaimer unique key * 1460/listing finder translations (#1473) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: getting started * fix: wip translations w/o changes * fix: wip updating content * fix: completed translations w/o questions * fix: rent placeholder handling * fix: removed json comment * fix: remove families program * fix: neighborhood translations * fix: hompage button fix * fix: added feature flagging * fix: missing env config * fix: update env naming * fix: template updates * feat: update leasing agent and developer translations (#1496) * 1486/listing finder refactor (#1487) * 1422/finder scaffolding + Q1 (#1448) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: mobile styling * fix: string + OnClick cleanup * 1434/listing finder q2 (#1452) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: pr cleanup * fix: typos + field value refactor * fix: auto-submit issue * 1443/listing finder disclaimer (#1461) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: remove unused div * fix: skip functionality + PR feedback * fix: refine react code * 1442/listing finder q3 (#1463) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div * 1444+5/listing finder q4+5 (#1472) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: remove empty div * fix: remove logs * fix: no results bug * fix: minor border issue * fix: disclaimer unique key * 1460/listing finder translations (#1473) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: getting started * fix: wip translations w/o changes * fix: wip updating content * fix: completed translations w/o questions * fix: rent placeholder handling * fix: removed json comment * fix: remove families program * fix: neighborhood translations * fix: hompage button fix * fix: added feature flagging * fix: component sync * fix: wip refactor * fix: wip 2 refactor * fix: wip 3 refactor * 1422/finder scaffolding + Q1 (#1448) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: mobile styling * fix: string + OnClick cleanup * 1443/listing finder disclaimer (#1461) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: remove unused div * fix: skip functionality + PR feedback * fix: refine react code * 1442/listing finder q3 (#1463) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div * fix: component sync * fix: wip refactor * fix: wip 2 refactor * fix: wip 3 refactor * fix: qa visual updates * fix: mobile header spacing refinement * fix: expand card componenet vars * fix: refined breakpoints * fix: removed unused css * fix: updated mobile header size * fix: simplified finder card css * fix: added missing translations (#1500) * fix: set neighborhood amenities to null when all sub fields empty (#1495) * fix: set neighborhood amenities to null when all sub fields empty * refactor: move neighborhood amenities on submit modification to formatter * fix: update for swagger changes (#1503) Co-authored-by: Yazeed Loonat <yazeedloonat@gmail.com> * feat: update neighborhood amenities fields (#1494) * fix: upgrade ioredis version (#1505) * fix: checkbox in bordered field in arabic (#1504) * fix: checkbox in bordered field in arabic * fix: update class names * fix: revert to existing padding Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com> * 1491/finder a11y fixes (#1493) * 1422/finder scaffolding + Q1 (#1448) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: mobile styling * fix: string + OnClick cleanup * 1434/listing finder q2 (#1452) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: pr cleanup * fix: typos + field value refactor * fix: auto-submit issue * 1443/listing finder disclaimer (#1461) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: remove unused div * fix: skip functionality + PR feedback * fix: refine react code * 1442/listing finder q3 (#1463) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div * 1444+5/listing finder q4+5 (#1472) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: remove empty div * fix: remove logs * fix: no results bug * fix: minor border issue * fix: disclaimer unique key * 1460/listing finder translations (#1473) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: getting started * fix: wip translations w/o changes * fix: wip updating content * fix: completed translations w/o questions * fix: rent placeholder handling * fix: removed json comment * fix: remove families program * fix: neighborhood translations * fix: hompage button fix * fix: added feature flagging * fix: component sync * fix: wip refactor * fix: wip 2 refactor * fix: wip 3 refactor * 1422/finder scaffolding + Q1 (#1448) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: mobile styling * fix: string + OnClick cleanup * 1443/listing finder disclaimer (#1461) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: remove unused div * fix: skip functionality + PR feedback * fix: refine react code * 1442/listing finder q3 (#1463) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div * fix: component sync * fix: wip refactor * fix: wip 2 refactor * fix: wip 3 refactor * fix: qa visual updates * fix: mobile header spacing refinement * fix: expand card componenet vars * fix: refined breakpoints * fix: removed unused css * fix: updated mobile header size * fix: simplified finder card css * fix: various focus/priority improvements * fix: added legend texts * fix: wip reset focus * fix: current focus solution * fix: prettier code style fixes Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> Co-authored-by: ColinBuyck <53269332+ColinBuyck@users.noreply.github.com> Co-authored-by: Krzysztof Zięcina <kriss.kontakt@gmail.com> Co-authored-by: Yazeed Loonat <yazeedloonat@gmail.com> Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com>

ColinBuyck added 3 commits October 19, 2022 14:52

fix: wip action block

cf63ab1

fix: custom block css

a629263

fix: matching spacing to figma

14eb6f5

ColinBuyck requested a review from ludtkemorgan October 20, 2022 23:42

ColinBuyck assigned ludtkemorgan Oct 20, 2022

ColinBuyck requested a review from YazeedLoonat October 20, 2022 23:42

ColinBuyck assigned YazeedLoonat Oct 20, 2022

ColinBuyck added the 2 reviews needed label Oct 20, 2022

ludtkemorgan approved these changes Oct 21, 2022

View reviewed changes

ludtkemorgan added 1 review needed and removed 2 reviews needed labels Oct 21, 2022

ColinBuyck requested a review from adriencyberspace October 21, 2022 18:50

ColinBuyck assigned adriencyberspace Oct 21, 2022

adriencyberspace approved these changes Oct 21, 2022

View reviewed changes

ColinBuyck added blocked by question Work is blocked by an open question and removed 1 review needed labels Oct 21, 2022

ColinBuyck mentioned this pull request Oct 21, 2022

1460/listing finder translations #1473

Merged

20 tasks

fix: removed custom styling

994b794

ColinBuyck merged commit 09bb9d0 into dev Oct 24, 2022

ColinBuyck deleted the 1449/filter-no-results branch October 24, 2022 23:14

ludtkemorgan pushed a commit that referenced this pull request Nov 16, 2022

1449/filter no results (#1476)

234a15c

* fix: wip action block * fix: custom block css * fix: matching spacing to figma * fix: removed custom styling

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1449/filter no results #1476

1449/filter no results #1476

ColinBuyck commented Oct 20, 2022 •

edited

Loading

netlify bot commented Oct 20, 2022 •

edited

Loading

netlify bot commented Oct 20, 2022 •

edited

Loading

netlify bot commented Oct 20, 2022 •

edited

Loading

ludtkemorgan Oct 21, 2022

ColinBuyck Oct 21, 2022

ludtkemorgan Oct 21, 2022

ColinBuyck Oct 21, 2022

slowbot Oct 24, 2022

adriencyberspace left a comment

1449/filter no results #1476

1449/filter no results #1476

Conversation

ColinBuyck commented Oct 20, 2022 • edited Loading

Pull Request Template

Issue Overview

Description

How Can This Be Tested/Reviewed?

Checklist:

Reviewer Notes:

On Merge:

netlify bot commented Oct 20, 2022 • edited Loading

✅ Deploy Preview for detroit-storybook-dev ready!

netlify bot commented Oct 20, 2022 • edited Loading

✅ Deploy Preview for detroit-partners-dev ready!

netlify bot commented Oct 20, 2022 • edited Loading

✅ Deploy Preview for detroit-public-dev ready!

ludtkemorgan Oct 21, 2022

Choose a reason for hiding this comment

ColinBuyck Oct 21, 2022

Choose a reason for hiding this comment

ludtkemorgan Oct 21, 2022

Choose a reason for hiding this comment

ColinBuyck Oct 21, 2022

Choose a reason for hiding this comment

slowbot Oct 24, 2022

Choose a reason for hiding this comment

adriencyberspace left a comment

Choose a reason for hiding this comment

ColinBuyck commented Oct 20, 2022 •

edited

Loading

netlify bot commented Oct 20, 2022 •

edited

Loading

netlify bot commented Oct 20, 2022 •

edited

Loading

netlify bot commented Oct 20, 2022 •

edited

Loading