fix: adding home type to model #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for detroit-partners-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-public-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-storybook-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -0,0 +1,14 @@ | |||
| import { MigrationInterface, QueryRunner } from "typeorm" | |||
|
|
|||
| export class addHomeTypes1668556487187 implements MigrationInterface { | |||
There was a problem hiding this comment.
I would have anticipated seeing a type created here for the home_type instead of character varying as happened here: https://github.com/CityOfDetroit/bloom/blob/dev/backend/core/src/migration/1649374032458-marketing-season.ts
Was this migration auto generated?
| @@ -175,6 +180,23 @@ const FormUnits = ({ listing, unitsSummaries, setSummaries, disableUnitsAccordio | |||
| grid={false} | |||
| separator | |||
| > | |||
| <GridSection columns={3} className={"pb-10"}> | |||
| <GridCell> | |||
| <p className="field-label">{t("listings.homeType")}</p> | |||
There was a problem hiding this comment.
You should be able to wrap this in <ViewItem> so the styling is consistent elsewhere, where we usually wraps selects in that component
|
|
ColinBuyck
changed the title
|
@emilyjablonski Thanks for the feedback! All of those comments should be addressed with the most recent commit 🐟 |
ludtkemorgan
pushed a commit
that referenced
this pull request
Dec 6, 2022
* fix: wip adding home type to model * fix: update for swagger changes * fix: backend swagger updates * fix: wip migration * fix: updated migration, detail + summary view * fix: clean up * fix: seeding + figma alignment * fix: added null default * fix: cleanup per pr feedback Co-authored-by: Yazeed Loonat <yazeedloonat@gmail.com>
ludtkemorgan
added a commit
that referenced
this pull request
Dec 13, 2022
* feat: change management company to contact information (#1507) * feat: add verified at field to listings (#1501) * fix: adding home type to model (#1502) * fix: wip adding home type to model * fix: update for swagger changes * fix: backend swagger updates * fix: wip migration * fix: updated migration, detail + summary view * fix: clean up * fix: seeding + figma alignment * fix: added null default * fix: cleanup per pr feedback Co-authored-by: Yazeed Loonat <yazeedloonat@gmail.com> * 1482/home type filter (#1510) * fix: wip adding home type to model * fix: update for swagger changes * fix: backend swagger updates * fix: wip migration * fix: updated migration, detail + summary view * fix: clean up * fix: seeding + figma alignment * fix: added null default * fix: home type filtering * fix: merge clean up * fix: single looping on home types Co-authored-by: Yazeed Loonat <yazeedloonat@gmail.com> * 1480/home types labels (#1511) * feat: add home type label to listing card * feat: add home type label to listing view * feat: add home type tag to existing listing tags array * feat: remove redundant homeType prop from ListingCard * feat: add translations (#1513) * feat: change leasing agent contact translations (#1517) Co-authored-by: Krzysztof Zięcina <kriss.kontakt@gmail.com> Co-authored-by: ColinBuyck <53269332+ColinBuyck@users.noreply.github.com> Co-authored-by: Yazeed Loonat <yazeedloonat@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Issue Overview
This PR addresses #1479
Description
This PR adds home types to the listing model and handles updating/viewing this information on the partner's side.
How Can This Be Tested/Reviewed?
This can be reviewed by logging into the partner's side and then selecting a listing. View the home type in the Unit Section, click edit, update it, and ensure that the new information is reflected in that same Unit Section.
Checklist:
yarn generate:clientand/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.