-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove components if they are the same in uic #1528
Conversation
✅ Deploy Preview for detroit-public-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-partners-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-partners-prod ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@@ -41,7 +39,7 @@ export interface ListingCardProps { | |||
footerContent?: React.ReactNode | |||
imageCardProps: ImageCardProps | |||
stackedTable?: boolean | |||
tableProps?: ListingCardTableProps | |||
tableProps?: any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temp fix for everything to play nicely, fixed soon in the individual component sync tickets
Pull Request Template
Issue Overview
This PR addresses #issue
Description
SiteHeader see how many discrepancies there are
Removed local, now pulling in the UIC version
Remaining discrepancies (most are very small), moved to detroit-ui-components
How Can This Be Tested/Reviewed?
Provide instructions so we can review.
Describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration.
Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.