Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove components if they are the same in uic #1528

Closed
wants to merge 5 commits into from

Conversation

emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Jan 20, 2023

Pull Request Template

Issue Overview

This PR addresses #issue

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

SiteHeader see how many discrepancies there are

Removed local, now pulling in the UIC version

  • ButtonGroup
  • ExpandableText
  • LocalizedLink
  • Video
  • Card
  • DashBlock
  • HousingCounselor
  • InfoCard
  • MediaCard
  • StatusBar
  • StatusItem
  • ExygyFooter
  • SiteFooter
  • DOBField
  • DateField
  • Dropzone
  • Form
  • HouseholdMemberForm
  • PhoneField
  • Select
  • Textarea
  • TimeField
  • All helpers/
  • HeaderBadge
  • PreferencesList
  • Breadcrumbs
  • TabNav
  • Tabs
  • AlertNotice
  • ApplicationStatus
  • ErrorMessage
  • SiteAlert
  • StatusAside
  • StatusMessage
  • Overlay
  • ApplicationTimeline
  • FormForgotPassword
  • ContentAccordion
  • ListingMap
  • ListingsGroup
  • UnitTables
  • Contact
  • ContactAddress
  • GetApplication
  • ListingUpdated
  • NumberedHeader
  • OrDivider
  • QuantityRowSection
  • ReferralApplication
  • SubmitApplication
  • DownloadLotteryResults
  • EventSection
  • FormSignIn
  • ForSignInAddPhone
  • FormSignInErrorBox
  • FormSignInMFACode
  • ResendConfirmationModal
  • All prototypes/
  • ContentSection
  • FooterSection
  • ListSection
  • MarkdownSection
  • ResponsiveContentList
  • ResponsiveWrappers
  • CategoryTable
  • MinimalTable
  • StackedTable
  • Message

Remaining discrepancies (most are very small), moved to detroit-ui-components

  • Button
  • ExpandableContent
  • LinkButton
  • ActionBlock
  • FormCard
  • ImageCard
  • Tooltip
  • ViewItem
  • Field
  • FieldGroup
  • AgPagination
  • Heading
  • HeadingGroup
  • Hero
  • PageHeader
  • SiteHeader
  • StepHeader
  • Icon
  • FooterNav
  • LanguageNav
  • ProgressNav
  • AlertBox
  • Drawer
  • LoadingOverlay
  • Modal
  • AdditionalFees
  • ListingCard
  • ListingDetailHeader
  • ListingDetails
  • ListingDividerLine
  • WhatToExpect
  • FormTerms
  • GridSection
  • InfoCardGrid
  • AgTable
  • GroupedTable
  • StandardTable
  • Description
  • Tag

How Can This Be Tested/Reviewed?

Provide instructions so we can review.

Describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • I have exported any new pieces added to ui-components
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@netlify
Copy link

netlify bot commented Jan 20, 2023

Deploy Preview for detroit-public-staging ready!

Name Link
🔨 Latest commit 4f635e2
🔍 Latest deploy log https://app.netlify.com/sites/detroit-public-staging/deploys/63caf68a3dd972000afcde7c
😎 Deploy Preview https://deploy-preview-1528--detroit-public-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 20, 2023

Deploy Preview for detroit-partners-staging ready!

Name Link
🔨 Latest commit 4f635e2
🔍 Latest deploy log https://app.netlify.com/sites/detroit-partners-staging/deploys/63caf68a10c7130008bd7b2e
😎 Deploy Preview https://deploy-preview-1528--detroit-partners-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 20, 2023

Deploy Preview for detroit-partners-prod ready!

Name Link
🔨 Latest commit 4f635e2
🔍 Latest deploy log https://app.netlify.com/sites/detroit-partners-prod/deploys/63caf68a88603e0008d35d02
😎 Deploy Preview https://deploy-preview-1528--detroit-partners-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -41,7 +39,7 @@ export interface ListingCardProps {
footerContent?: React.ReactNode
imageCardProps: ImageCardProps
stackedTable?: boolean
tableProps?: ListingCardTableProps
tableProps?: any
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temp fix for everything to play nicely, fixed soon in the individual component sync tickets

@emilyjablonski emilyjablonski changed the base branch from main to dev January 30, 2023 22:08
@emilyjablonski emilyjablonski changed the base branch from dev to main January 30, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants