fix: under construction #1607
fix: under construction #1607
Conversation
✅ Deploy Preview for detroit-storybook-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-public-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-partners-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| let label = t("listings.apply.applicationSeason") | ||
| if (listing?.marketingSeason) { | ||
| label = label.concat(` ${t(`seasons.${listing.marketingSeason}`)}`) | ||
| } | ||
| if (listing?.marketingDate) { | ||
| label = label.concat(` ${dayjs(listing.marketingDate).year()}`) | ||
| } | ||
| return label | ||
| } |
There was a problem hiding this comment.
I think it works for this case in the languages we support, but there is a chance that a language wouldn't have the same order in the sentence.
For example we might say "Residents should apply in Spring 2023" but another language it could be more appropriate to say "In Spring 2023 residents should apply".
I don't think we have to do it for this one, but usually with these translations you should pass the season and year as parameters to the translation string.
There was a problem hiding this comment.
@ColinBuyck my assumption would also be to include the message even when no season is listed although @sarahlazarich might have a different recommendation.
Font weight discrepancy seems to be between the figma component and what you have in the code, but lets keep it 500 for consistency with the rest of the application. I added the free font awesome version to the mockup (solid) for access, but if you are using the hollow one consistently, then go ahead and use it here as well. Thanks for double checking!
|
@ColinBuyck - if there are no what to expect translations, I think it's fine to not implement translations here. And I agree with Em's recommendation above. |
* fix: add new strings * fix: text and ui implementation * fix: text and remaining ui implementation * fix: update metadata formatter * fix: variable naming cleanup
* fix: under construction (#1607) * fix: add new strings * fix: text and ui implementation * fix: text and remaining ui implementation * fix: update metadata formatter * fix: variable naming cleanup * fix: remove markdown files from prettier --------- Co-authored-by: ColinBuyck <53269332+ColinBuyck@users.noreply.github.com>
Pull Request Template
Issue Overview
This PR addresses #1564
Description
This PR changes all visual references of "Coming Soon" to "Under Construction" without making any backend changed. This includes image tag labeling, homepage "under construction section", filtering, what to Expect text, partner's form questions and details, and a new display pattern to highlight when residents should apply.
Note (cc @eajensenwa):
I made the decision to still include the "Residents should apply in..." messaging when there was only a year present but no season since I felt it was still applicable for properties that wouldn't be open for a while and didn't have a season yet set. Let me know if this is what you'd expect.
Also, made two small assumptions on the "Residents should apply in" Figma. One that the font weight of 400 in the design differing from the Alert Box default of 500 is not worth pursuing customization. Secondly, the icon used in the Figma isn't one of our internal icons (hollow info icon is but solid is not) and with how we type the Alert Box component we would have to make a change to the component in UI-C. I assumed this change was also not worth the additional time. Let me know if you agree with these assumptions!
Note (cc @sarahlazarich ): There aren't currently any what to expect translations so I did not implement the "This property is still under construction" translations
How Can This Be Tested/Reviewed?
One way to test this would be to pull this down locally, reseed!, and create a new listing.
Checklist:
yarn generate:clientand/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.