Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to http #1665

Closed
wants to merge 1 commit into from
Closed

fix: update to http #1665

wants to merge 1 commit into from

Conversation

ColinBuyck
Copy link
Collaborator

@ColinBuyck ColinBuyck commented Oct 9, 2024

Pull Request Template

Issue Overview

This PR addresses #1664

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Updates the link to http so that image loads

How Can This Be Tested/Reviewed?

See the SW image present on the homepage

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for detroit-public-dev ready!

Name Link
🔨 Latest commit de08bf8
🔍 Latest deploy log https://app.netlify.com/sites/detroit-public-dev/deploys/6706b8cf1ee7a40008a1cb7e
😎 Deploy Preview https://deploy-preview-1665--detroit-public-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for detroit-partners-dev ready!

Name Link
🔨 Latest commit de08bf8
🔍 Latest deploy log https://app.netlify.com/sites/detroit-partners-dev/deploys/6706b8cfa0888c0008806d4f
😎 Deploy Preview https://deploy-preview-1665--detroit-partners-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -14,7 +14,7 @@ export const regionImageUrls: Map<Region, string> = new Map([
],
[
Region.Southwest,
"https://www.theneighborhoods.org/sites/the-neighborhoods/files/2020-10/Southwest-Mural_1.jpg",
"http://www.theneighborhoods.org/sites/the-neighborhoods/files/2020-10/Southwest-Mural_1.jpg",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may cause our site to be considered unsecure since we'd be making an http call for an image

wondering if we can ask to move this image under cloudinary

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide some resources on the security concerns? Preferably https 🥲

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it looks like Yazeed might be on to something here. https://webmasters.stackexchange.com/questions/87987/https-connection-is-not-safe-due-to-images. Could we potentially reach out to someone to see if we can use this image and host it locally?

@YazeedLoonat
Copy link
Collaborator

@ludtkemorgan curious for your thoughts on that question

@ColinBuyck
Copy link
Collaborator Author

Not the right path based on the vulnerability that Yazeed referenced

@ColinBuyck ColinBuyck closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants