-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update to http #1665
fix: update to http #1665
Conversation
✅ Deploy Preview for detroit-public-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for detroit-partners-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -14,7 +14,7 @@ export const regionImageUrls: Map<Region, string> = new Map([ | |||
], | |||
[ | |||
Region.Southwest, | |||
"https://www.theneighborhoods.org/sites/the-neighborhoods/files/2020-10/Southwest-Mural_1.jpg", | |||
"http://www.theneighborhoods.org/sites/the-neighborhoods/files/2020-10/Southwest-Mural_1.jpg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may cause our site to be considered unsecure since we'd be making an http call for an image
wondering if we can ask to move this image under cloudinary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide some resources on the security concerns? Preferably https 🥲
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately it looks like Yazeed might be on to something here. https://webmasters.stackexchange.com/questions/87987/https-connection-is-not-safe-due-to-images. Could we potentially reach out to someone to see if we can use this image and host it locally?
@ludtkemorgan curious for your thoughts on that question |
Not the right path based on the vulnerability that Yazeed referenced |
Pull Request Template
Issue Overview
This PR addresses #1664
Description
Updates the link to http so that image loads
How Can This Be Tested/Reviewed?
See the SW image present on the homepage
Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.