Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cast from enum to string before lowercasing in filtered query #264

Merged
merged 3 commits into from
Jul 26, 2021

Conversation

avaleske
Copy link

@avaleske avaleske commented Jul 26, 2021

Issue #202

Addresses #202

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

In #257 we added lowercased the comparison in addFilters() so that it would be case-insensitive, but that broke comparisons with enum types.
To fix this, we cast all types to strings in the query

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/address technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

Please describe the tests that you ran to verify your changes. Provide instructions so we can review. Please also list any relevant details for your test configuration

  • Desktop View
  • Mobile View
  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes

@avaleske avaleske requested a review from willrlin July 26, 2021 16:38
Copy link

@pfeeny5 pfeeny5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and fixed the issue.

@willrlin willrlin merged commit 5f9326f into main Jul 26, 2021
@willrlin willrlin deleted the avaleske/fix-lowercase-enum-in-query branch July 26, 2021 17:34
seanmalbert pushed a commit that referenced this pull request Jun 23, 2022
* adds cast from enum to string before lowercasing
* update changelog
* Fix listings.service test.

Co-authored-by: Will Lin <wrl@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants