Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cypress tests and add them to Travis. #305

Merged
merged 26 commits into from
Aug 4, 2021
Merged

Fix Cypress tests and add them to Travis. #305

merged 26 commits into from
Aug 4, 2021

Conversation

willrlin
Copy link

@willrlin willrlin commented Aug 2, 2021

Issue

Addresses #171

Description

Fix the Cypress tests and add them to the Travis config.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/address technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

Run cypress tests with yarn test:apps.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes

Copy link

@anders-schneider anders-schneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Two questions below, but not blocking

@willrlin
Copy link
Author

willrlin commented Aug 4, 2021

Only one portion of the member.spec.ts test is flaky (passes on one branch and locally, but not the pull request branch), so I'm going to disable just that part in the interest of getting all the rest of these running on presubmit. It also seems likely that we may want to delete some of those tests anyway once we remove applications.

@willrlin willrlin merged commit 3a3aa69 into main Aug 4, 2021
@willrlin willrlin deleted the 171/cypress-tests branch August 4, 2021 20:53
seanmalbert pushed a commit that referenced this pull request Jun 23, 2022
Small fixes to get the cypress tests running and add them to our Travis presumit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants