-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Cypress tests and add them to Travis. #305
Conversation
If the getInitialProps fails, the page will fail to render. So make the rendering optional so that at least the empty page will be able to be displayed.
Removes the check for counselors and just check that the empty page loads.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Two questions below, but not blocking
Only one portion of the member.spec.ts test is flaky (passes on one branch and locally, but not the pull request branch), so I'm going to disable just that part in the interest of getting all the rest of these running on presubmit. It also seems likely that we may want to delete some of those tests anyway once we remove applications. |
Small fixes to get the cypress tests running and add them to our Travis presumit.
Issue
Addresses #171
Description
Fix the Cypress tests and add them to the Travis config.
Type of change
How Can This Be Tested/Reviewed?
Run cypress tests with
yarn test:apps
.Checklist: