Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the COUNTY_CODE to Detroit. #351

Merged
merged 5 commits into from
Aug 9, 2021
Merged

Update the COUNTY_CODE to Detroit. #351

merged 5 commits into from
Aug 9, 2021

Conversation

willrlin
Copy link

@willrlin willrlin commented Aug 5, 2021 •
edited
Loading

Issue

Addresses #49, dependency for #341.

  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue

Description

Change the default values to Detroit for the CountyCode everywhere.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change is a refactor/address technical debt

How Can This Be Tested/Reviewed?

There aren't any UI changes in this PR.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes

@willrlin willrlin requested a review from elenm August 5, 2021 20:11
@willrlin willrlin mentioned this pull request Aug 5, 2021
Merged
23 tasks
@willrlin willrlin assigned willrlin and unassigned elenm Aug 9, 2021
@willrlin willrlin merged commit b01fb0f into main Aug 9, 2021
@willrlin willrlin deleted the 49/detroit-data branch August 9, 2021 15:52
seanmalbert pushed a commit that referenced this pull request Jun 23, 2022
@willrlin
Update the COUNTY_CODE to Detroit. (#351)
f39b42d 
* Update the COUNTY_CODE to Detroit.
* Update the CHANGELOG
* Fix email.service.spec.ts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenm elenm elenm approved these changes

Assignees

@willrlin willrlin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willrlin @elenm