Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RTL plugin. #627

Merged
merged 5 commits into from
Sep 23, 2021
Merged

Add RTL plugin. #627

merged 5 commits into from
Sep 23, 2021

Conversation

willrlin
Copy link

Issue

Description

Adds the tailwindcss-rtl plugin to be able to use start and end styles instead of left/right. Automatically switches the direction of the app based on the locale.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/address technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

Viewed the site and swapped between different languages. Fixes for RTL mode will be made in other PRs.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes
  • I have run yarn generate:client if I made backend changes

willrlin and others added 3 commits September 22, 2021 16:05
@willrlin
Start adding RTL plugin
2a6fb16
@seanmalbert @willrlin
sets tailwindcss to version 7
dbb5b2e 
Apparently there's some package that's incompatible with tailwind v8.
@willrlin
Set the dir based on the locale.
9c193c4
@willrlin willrlin merged commit b8fa7d1 into main Sep 23, 2021
@willrlin willrlin deleted the 495/add-rtl-plugin branch September 23, 2021 15:43
seanmalbert added a commit that referenced this pull request Jun 23, 2022
@willrlin @seanmalbert
Add RTL plugin. (#627)
e9e71c3 
* Start adding RTL plugin

* sets tailwindcss to version 7

Apparently there's some package that's incompatible with tailwind v8.

* Set the dir based on the locale.

* Update CHANGELOG

* Downgrade autoprefixer to match PostCSS.

Co-authored-by: Sean Albert <smabert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfeeny5 pfeeny5 pfeeny5 approved these changes

@abbiefarr abbiefarr Awaiting requested review from abbiefarr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RTL] add tailwind rtl plugin for automatic direction switching
3 participants
@willrlin @pfeeny5 @seanmalbert