Update NeoScan #56
Merged
Update NeoScan #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
neoscan appears to get stuck when minting tokens (happened in the previous version too). Investigating this some more as per our convo in discord |
|
@jeroenptrs Is this PR blocked until that issue is resolved? |
|
@revett not really. It works the same as before, just the fact that minting tokens doesnt work right now (or at least using the c# example). |
jeroenptrs
approved these changes
Oct 1, 2018
There was a problem hiding this comment.
Aside from an already existing issue, this works fine. Putting minttokens into a separate issue now
cc @revett
|
Might be worth to update neo-python to version 0.7.8 as well, as the notifications-server uses the latest one. Having trouble with creating wallets and opening them as neo-python versions differ |
|
@corck I'll do that in a subsequent PR, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Neoscan is outdated because new version separate block syncing with api/web function
Solution
docker-compose.yml is updated, status is updated to look for 7 services
Notes
VERSIONfile using semver 📝