Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conform to spec #4

Merged
merged 2 commits into from
Sep 28, 2018
Merged

Conversation

ian-r-rose
Copy link
Contributor

@ian-r-rose ian-r-rose commented Sep 21, 2018

  1. Draws accuracy from a Rayleigh distribution with mode around 5 meters. May or may not be reasonable, but a fine place to start, I think.
  2. Casts properties to an integer as the spec demands. I think the spec should probably relax on this front and allow floating point numbers, but this is what it says for now.

I have not updated the event_location field to be a Point, since the spec does not say that just yet.

Edit: whoops, I see that the spec does now specify point.

Fixes #3

@ian-r-rose
Copy link
Contributor Author

Okay, Point is fixed.

@thekaveman
Copy link
Contributor

I'd honestly like us to standardize around Feature and FeatureCollection in all of these cases, as hinted at in openmobilityfoundation/mobility-data-specification#74 and proposed in https://github.com/CityOfLosAngeles/mobility-data-specification#73. This would allow accuracy and other related properties to co-exist with the geo-data in an easily extensible manner. It also follows from our (buried) discussion on the JSON Schema work

@ian-r-rose
Copy link
Contributor Author

Ah, I misunderstood. I can revert that last commit, or we can hang out here until openmobilityfoundation/mobility-data-specification#74 is resolved.

@thekaveman
Copy link
Contributor

Yeah...that last comment got lost in there. I'm hoping we'll have that issue tied up in the next few days, but I'll leave it up to you. I'm good to merge the other changes if you want to revert, or I'm good to wait it out as things may still be changing...

@thekaveman
Copy link
Contributor

@ian-r-rose can you revert that last commit, given the latest developments in MDS? Then I can get the other changes merged in.

@ian-r-rose
Copy link
Contributor Author

Yep, reverted!

@thekaveman thekaveman merged commit c8e5b6a into CityofSantaMonica:master Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants