Thread edit refresh #216
Merged
Thread edit refresh #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brylie
requested changes
Aug 6, 2018
project/webapp/static/js/thread.js
Outdated
| responseWrapper: _.template($('#thread-response-template').html()), | ||
| outlineTemplate: _.template($('#outline-template').html()), | ||
|
|
||
| initialize: function (options) { | ||
| console.log('sanity check') |
brylie
requested changes
Aug 6, 2018
project/webapp/static/js/thread.js
Outdated
| this.$('.thread-wiki-holder').addClass('hide'); | ||
| this.$('.thread-body-holder').removeClass('hide'); | ||
| this.$('.thread-body-holder').css({display: 'block'}); | ||
|
|
||
| this.resizeBodyToWindow(); | ||
|
|
||
| this.renderOutline(); | ||
| this.renderOutline();//THISTHIS |
project/webapp/static/js/thread.js
Outdated
| this.$('.main-thread').on('scroll', function (e) { | ||
| _this.processCiviScroll(); | ||
| }); | ||
| } | ||
| }, | ||
|
|
||
| threadNavRender: function () { |
There was a problem hiding this comment.
Add docstring describing purpose of this function.
brylie
approved these changes
Aug 9, 2018
|
@saxonhouse Could you edit the initial pull request comment with a key word to include the issue you are closing? Please refer to https://help.github.com/articles/closing-issues-using-keywords/ if you need info on that. I will merge after that change is made. |
|
Nevermind, I got it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix calls render functions to update thread info after edit.
While working on this I noticed (in firefox) the scroll after returning from the edit window hides the title bar. Will look into this too.
@JL24 review request
Update: Extra commits after realising the civi scroll was disrupted at first
Resolves #213