Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building s390 with LLVM=1 #710

Closed
nathanchance opened this issue Feb 14, 2024 · 2 comments
Closed

Add support for building s390 with LLVM=1 #710

nathanchance opened this issue Feb 14, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@nathanchance
Copy link
Member

LLD has gained s390 support in main (and hopefully 18.1.0):

llvm/llvm-project@fe3406e
llvm/llvm-project#81675

There were several issues uncovered on the Linux side that needed to be fixed:

ClangBuiltLinux/linux#1991
ClangBuiltLinux/linux#1992
ClangBuiltLinux/linux#1993
ClangBuiltLinux/linux#1994
ClangBuiltLinux/linux#1995

Once all of those changes are available in -next and apt.llvm.org has been updated to include that LLVM change, we should cut all of the relevant LLVM builds on -next over to linking with ld.lld. Ideally, we would just cut over to LLVM=1 OBJCOPY=s390x-linux-gnu-objcopy OBJDUMP=s390x-linux-gnu-objdump, as that is known to work with all of the configurations that we test.

@nathanchance nathanchance added enhancement New feature or request blocked (linux) Blocked on an issue with Linux upstream blocked (llvm) Blocked on an issue with LLVM upstream labels Feb 14, 2024
@nathanchance nathanchance self-assigned this Feb 14, 2024
@nathanchance nathanchance removed blocked (linux) Blocked on an issue with Linux upstream blocked (llvm) Blocked on an issue with LLVM upstream labels Feb 16, 2024
nathanchance added a commit to nathanchance/continuous-integration2 that referenced this issue Feb 16, 2024
… with LLVM tip of tree

s390 support in ld.lld has recently landed in the main branch of LLVM.
With this, it makes sense to start cutting s390 over to full LLVM=1,
versus the current situation of just CC=clang.  linux-next is the only
tree that currently has the necessary changes to support ld.lld but they
will trickle down to other trees in time.

llvm-objcopy currently works on LLVM main as well but that needs a
kernel side fix to boot properly, so we will stick with GNU objcopy
until that is fixed.

Closes: ClangBuiltLinux#710
Link: ClangBuiltLinux/linux#1996
Link: llvm/llvm-project@fe3406e
Link: llvm/llvm-project@3c02cb7
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
@nathanchance nathanchance changed the title Add support for building s390 with LD=ld.lld Add support for building s390 with LLVM=1 Feb 21, 2024
@nathanchance
Copy link
Member Author

I have updated the title to reflect that:

With this, we can cut over to full LLVM=1 with ARCH=s390 with Linux trees and LLVM toolchains that satisfy these conditions (we will have to validate the versions of LLVM that tuxsuite has available).

@nathanchance
Copy link
Member Author

#712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant