Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the integrated assembler for s390 on -next and mainline #367

Merged
merged 3 commits into from
May 24, 2022

Conversation

nathanchance
Copy link
Member

@nathanchance nathanchance commented May 18, 2022

The s390 folks are requiring LLVM 14 and newer so that the integrated
assembler can be used. Remove these builds for -next and mainline, as
they won't be able to start.

The s390 folks have updated their asm to work with the integrated
assembler. Enable it for s390 builds on -next and mainline.

We cannot switch to LLVM=1 because ld.lld and llvm-objcopy do not
support s390:

ClangBuiltLinux/linux#1524
ClangBuiltLinux/linux#1530

For now, we will just use CC=clang LLVM_IAS=1.

Closes: #363
Link: https://git.kernel.org/s390/c/8218827b73c6e41029438a2d3cc573286beee914

Copy link
Member

@nickdesaulniers nickdesaulniers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tested that LLVM_IAS=1 works today for s390? I thought @hcahca 's kernel patches were pending, and would depend further on
https://reviews.llvm.org/D125982
llvm/llvm-project#55411 (comment)

@nathanchance
Copy link
Member Author

nathanchance commented May 19, 2022

I’ll check my build logs from last night but the patches were in next-20220518:

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/arch/s390?h=next-20220518

There is a patch on the kernel side to work around that issue.

@hcahca
Copy link

hcahca commented May 19, 2022

Maybe @hcahca can clarify, will either:
1. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/arch/s390?h=next-20220518&id=e9953b729b789c0e2984859e3b2170b7fa8520d5 land, with the requirement of clang-14, or

We will go this route (option 1). As soon as clang-15 is released we might increase the required clang version once again - just to avoid that somebody by accident adds new code which otherwise would be silently miscompiled with clang-14.

@nathanchance
Copy link
Member Author

I'll wait for https://lore.kernel.org/Yot+xzLZETNTxNo+@osiris/ to be merged into mainline then I'll update this pull to turn the integrated assembler on for mainline and -next.

The s390 folks are requiring LLVM 14 and newer so that the integrated
assembler can be used. Remove these builds for -next and mainline, as
they won't be able to start.

Link: https://git.kernel.org/s390/c/8218827b73c6e41029438a2d3cc573286beee914
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
…inline

The s390 folks have updated their asm to work with the integrated
assembler. Enable it for s390 builds on -next and mainline.

We cannot switch to LLVM=1 because ld.lld and llvm-objcopy do not
support s390:

ClangBuiltLinux/linux#1524
ClangBuiltLinux/linux#1530

For now, we will just use 'CC=clang LLVM_IAS=1'.

Closes: ClangBuiltLinux#363
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
@nathanchance nathanchance changed the title Enable the integrated assembler for s390 on -next Enable the integrated assembler for s390 on -next and mainline May 24, 2022
@nathanchance
Copy link
Member Author

Alright, this should be good to go now.

Copy link
Member

@nickdesaulniers nickdesaulniers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! Thanks @nathanchance and @hcahca . 🎆 🥳

@nathanchance nathanchance merged commit e27c7db into ClangBuiltLinux:main May 24, 2022
@nathanchance nathanchance deleted the update-s390-next branch May 25, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test s390 with integrated as
3 participants