feat: Add Embed #61

[Dhanus3133]

Added Embed Feature

Solves #61
/claim #61

[Dhanus3133]

@alxlion I made it as a text_input instead of textarea here. When I try textarea the user input value are not been updated not sure what the issue was though.

[alxlion]

I'll check that asap this week, thanks !

[joleaf]

I think, that there should be a way to set the current embed inactive. Because, if it is activated, and you want to show the slide again, currently there is no way to do it.

So, there should be a way to deactivate the active embed, e.g. by clicking on "Active"

[Dhanus3133]

@joleaf thanks for your feedback. I've now added that feature to toggle the status for everything (form, poll, embed)

[alxlion]

I've encountered several bugs:

1 - No more import button on interactions popup

2 - When you enable a poll and then an embed, the embed doesn't show (presenter + attendee view).

In the specs, I said "When an embed is enabled and is in the current slide position, show it in full screen.". Currently, the embed is not in full screen. It needs to be in full screen like the slide without hiding attendees messages.

I didn't define what to show on the attendee view, I noticed that you display the current embed. This could be good but only if the user select "Attendee can access the embed on the device" when creating an embed.

Good job for what you did 👍

[Dhanus3133]

@alxlion I am not sure why it doesn't work for you. I've checked(again) on both the points you have mentioned, seems to be working fine for me but displaying it in full screen is still an issue, I will also look into the changes you told too. Can you check it again? Thanks

[Dhanus3133]

I didn't define what to show on the attendee view, I noticed that you display the current embed. This could be good but only if the user select "Attendee can access the embed on the device" when creating an embed.

Just to confirm are you mentioning to add "Enable Embed" in the Attendee settings something like this

[alxlion]

I didn't define what to show on the attendee view, I noticed that you display the current embed. This could be good but only if the user select "Attendee can access the embed on the device" when creating an embed.

Just to confirm are you mentioning to add "Enable Embed" in the Attendee settings something like this

I thought this would happen during embed creation, with a checkbox in the form.

I am not sure why it doesn't work for you. I've checked(again) on both the points you have mentioned, seems to be working fine for me but displaying it in full screen is still an issue, I will also look into the changes you told too. Can you check it again? Thanks

I'll check that asap

[alxlion]

Hey @Dhanus3133 , i checked your last commits, it works well ! The last step remaining is showing the embed in fullscreen 😃

[Dhanus3133]

Great! I have also found an issue with the shortcut key, using the phx-key causes a clash and toggle happens also with the input fields in the popup window. I have tried disabling the event when it is in the input field but failed, will again try that and there is any other way to avoid this problem? And on the fullscreen should that be only for the presenter right without hiding messages?

[alxlion]

Great! I have also found an issue with the shortcut key, using the phx-key causes a clash and toggle happens also with the input fields in the popup window. I have tried disabling the event when it is in the input field but failed, will again try that and there is any other way to avoid this problem?

It is because of the ClaperWeb.Component.Input.check in manage.html.heex, to fix it you have to replace shortcut by a condition like:

shortcut={if @create == nil, do: "Q", else: nil}

And on the fullscreen should that be only for the presenter right without hiding messages?

Yes full-screen only on the presenter mode

[Dhanus3133]

Hi @alxlion , I've addressed the changes you mentioned. Could you please review when you have time? Thanks!

[alxlion]

Nice work 🥳 ! I made some change request just to change "embed" to "web content" in the views, "embed" could be too technical for some users.
And add a validation rule to allow only iframe in the content.

I will merge and validate the PR after that 😉

[joleaf]

Is it possible to paste only the youtube link? Because i think some users may not know how to create an iframe..

[alxlion]

Is it possible to paste only the youtube link? Because i think some users may not know how to create an iframe..

Using an iframe may present a technical challenge for some users, yet it offers greater versatility in terms of the content that can be embedded. For instance, embedding a Google Slide directly using its URL is not possible. Instead, it requires additional steps: navigate to 'File', 'Share' and select 'Publish to web', and then copy the provided iframe code.

I favor the approach of supplying comprehensive documentation that guides users through the process of embedding various types of content, such as YouTube, Vimeo, or Google Slides. This is preferable to limiting the ability to embed content to a few services that can be embedded only with a simple URL.

[Dhanus3133]

And add a validation rule to allow only iframe in the content.

Committed the changes for validating the embed.

[alxlion]

@Dhanus3133 Well played! Your PR has been merged 😉