fix: types for list apps

Clarifai · Feb 28, 2024 · d77df11 · d77df11
1 parent 8ab1276
commit d77df11
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/src/client/lister.ts b/src/client/lister.ts
@@ -43,10 +43,10 @@ export class Lister extends BaseClient {
     while (true) {
       // Prepare request data
       // @ts-expect-error - TS doesn't know that the method exists
-      requestData["page"] = page;
+      requestData.setPage(page);
       if (perPage) {
         // @ts-expect-error - TS doesn't know that the method exists
-        requestData["per_page"] = perPage;
+        requestData.setPerPage(perPage);
       }
 
       // Perform gRPC request

diff --git a/src/client/user.ts b/src/client/user.ts
@@ -1,7 +1,10 @@
 // import { StatusCode } from "clarifai-nodejs-grpc/proto/clarifai/api/status/status_code_pb";
 import { Lister } from "./lister";
 import { KWArgs } from "../utils/types";
-import { ListAppsRequest } from "clarifai-nodejs-grpc/proto/clarifai/api/service_pb";
+import {
+  ListAppsRequest,
+  MultiAppResponse,
+} from "clarifai-nodejs-grpc/proto/clarifai/api/service_pb";
 import { mapParamsToRequest, promisifyGrpcCall } from "../utils/misc";
 
 // interface UserAppID {
@@ -36,12 +39,19 @@ export class User extends Lister {
       | Record<string, never>;
     pageNo?: number;
     perPage?: number;
-  }) {
+  }): AsyncGenerator<MultiAppResponse, void, unknown> {
     const listApps = promisifyGrpcCall(this.STUB.client.listApps);
     const request = new ListAppsRequest();
     mapParamsToRequest(params, request);
 
-    yield this.listPagesGenerator(listApps, request, pageNo, perPage);
+    for await (const item of this.listPagesGenerator(
+      listApps,
+      request,
+      pageNo,
+      perPage,
+    )) {
+      yield item;
+    }
   }
 
   //   async listRunners(