use file-upload strategy of zoho to upload larger content #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanspolo
reviewed
Nov 21, 2023
zoho.go
Outdated
| if additionalHeaders == nil { | ||
| additionalHeaders = map[string]string{} | ||
| } | ||
| additionalHeaders["User-Agent"] = "ZohoAnalytics GoLibrary" |
There was a problem hiding this comment.
du überschreibst damit auch, wenn jemand von außen einen User-Agent reingeben will.
Kannst da noch einen Check davor packen, dann ist es etwas robuster, außer du möchtest dieses Verhalten auf jeden Fall haben.
hanspolo
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change file-upload strategy.
The current implemented strategy is using a header-param to transfer the data. The better way is to upload the CSV-Data as multipart/form-data.
Zoho Docu: https://www.zoho.com/analytics/api/#import-data
Change is made without breaking change for use of this lib.