Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to remove data on uninstall and code modernization #175

Merged
merged 7 commits into from
Jul 4, 2024
Merged

Add option to remove data on uninstall and code modernization #175

merged 7 commits into from
Jul 4, 2024

Conversation

xxsimoxx
Copy link
Member

  • Add option to remove data on uninstall (in General Settings > Misc)
  • Remove automatic deactivation of conflicting plugins (that wasn't working)
  • Remove unused Update class
  • Fix some more PHP deprecations

@xxsimoxx xxsimoxx requested a review from KTS915 July 2, 2024 05:55
KTS915
KTS915 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@KTS915 KTS915 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably not the best person to review this because I don't use SEO plugins, but my tests on my localhost test site showed everything working as expected. So it LGTM!

@xxsimoxx xxsimoxx merged commit 050cc17 into ClassicPress:master Jul 4, 2024
@xxsimoxx xxsimoxx deleted the codecheck branch July 4, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KTS915 KTS915 KTS915 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xxsimoxx @KTS915