fix: Generated source files end in .g.cs #19
Conversation
| @@ -59,7 +61,11 @@ private static void Execute(GeneratorExecutionContext context, IEnumerable<Metho | |||
|
|
|||
| foreach (var (path, source) in replacedTypes) | |||
| { | |||
| context.AddSource(Path.GetFileNameWithoutExtension(path)+$"_expressionify_{i++}.cs", SourceText.From(source.ToFullString(), Encoding.UTF8)); | |||
| var sourceCode = NullableDirective + source.ToFullString(); | |||
There was a problem hiding this comment.
Note: I'm adding #nullable enable to all generated sources, as otherwise the generated code won't compile with the error CS8669: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. Auto-generated code requires an explicit '#nullable' directive in source. (which is a warning, but we have WarningsAsErrors enabled)
Not sure, if this is fine for "legacy" projects where nullable is disabled, as I don't have any bigger old project to test it in, where we also use Expressionify...
There was a problem hiding this comment.
I'm also not fully sure about old projects, but from all I could find it seemed fine.
| @@ -73,7 +84,49 @@ public partial class Nested | |||
| private static System.Linq.Expressions.Expression<System.Func<int, int>> Foo_Expressionify_0 { get; } = (int x) => 8; | |||
| } | |||
| } | |||
| }", TestName = "File scoped namespace")] | |||
| }", TestName = "Nested class")] | |||
There was a problem hiding this comment.
I personally find these test cases a bit hard to read, but that's not specifically something introduced here. Tried a bit with TestCaseSource, but never got to anything I was happy with.
Fixes #18