Create data/minicubes directory if it doesn't already exist #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents an AssertionError on the partial-inputs jupyter notebook.
yellowcap
reviewed
Feb 23, 2024
docs/partial-inputs.ipynb
Outdated
| @@ -204,7 +204,7 @@ | |||
| "outputs": [], | |||
| "source": [ | |||
| "outdir = Path(\"data/minicubes\")\n", | |||
| "assert outdir.exists()\n", | |||
| "outdir.mkdir(exist_ok=True)\n", | |||
There was a problem hiding this comment.
Would this need parents=True as well for folks that don't have the data directory yet?
There was a problem hiding this comment.
Good catch! Forgot that parents=False is the default at https://docs.python.org/3/library/pathlib.html#pathlib.Path.mkdir. I've added parents=True in commit 6921c5a, and made sure that the partial-inputs-flood-tutorial.ipynb notebook has that too.
Oh, and I've also fixed a small typo in the huggingface checkpoint URL in 08aa4fd 😉
Ensure that the data/ folder is also created if it doesn't already exist.
yellowcap
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents an AssertionError on the partial-inputs jupyter notebook when the
data/minicubesfolder doesn't exist, by just creating the folder!Patches #149