Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for no data on a tile level in sentinel 1 vv and vh, sentinel 2 and DEM #60

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

lillythomas
Copy link
Contributor

Adjusts the tiler function to check for nodata in not just Sentinel 2, but also Sentinel 1 VV and VH as well as the DEM.

@lillythomas lillythomas requested a review from yellowcap December 1, 2023 07:01
@weiji14 weiji14 mentioned this pull request Dec 4, 2023
@yellowcap
Copy link
Member

yellowcap commented Dec 6, 2023

Closes #68

Copy link
Member

@yellowcap yellowcap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nodata filter for float 32 needs to be slightly different.

@weiji14 weiji14 linked an issue Dec 6, 2023 that may be closed by this pull request
@weiji14 weiji14 added the data-pipeline Pull Requests about the data pipeline label Dec 6, 2023
@yellowcap
Copy link
Member

Rebased from main, and added small fix on the routine ("DEM" band is named lowercase "dem" in the tile xarray)

@yellowcap yellowcap merged commit f5e3100 into main Dec 7, 2023
@yellowcap yellowcap deleted the nodata_filter branch December 7, 2023 14:33
brunosan pushed a commit that referenced this pull request Dec 27, 2023
… and DEM (#60)

* check for no data on a tile level in sentinel 1 vv and vh, sentinel 2 and DEM

* adjust to run consecutively instead of all together, prevents unnecesary calculations

* adjust per nodata type in other bands

* Simplify nodata check by converting to loop

---------

Co-authored-by: Daniel Wiesmann <daniel@wiesmann.pt>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-pipeline Pull Requests about the data pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catch Nodata for S1 and DEM
3 participants