"No tests found" now results in a failure. #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests for Tests for |
+ Moved location of "No tests found" failure logic to wasSuccessful() + Updated test_wasSuccessful so assert that 0 passes and 0 fails results in a failure. + Updated test_noTestsFound to verify that result.testsRun is 0 and wasSuccessful is False
|
Alrighty, I updated things and added (well, modified) the relevant tests. I moved the logic for pass/fail out of I also squashed the commits so that you have a nice clean history (though there were only 2 commits originally...). Once tests pass, I think it's ready to go. They passed locally so hopefully they do the same on CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123.
This changes the return value and text coloring when no tests are found.
I wasn't able to figure out where any unit tests for this should go (I have limited time today), so if you could let me know where they should go, I'll try writing some tomorrow.