Drop code that explicitly supported python 2. #269
Conversation
Tested with `green green` with python 3.6 (some of the test code uses f-strings so we cannot test with python 3.5).
|
It's the end of an era. 😢 Time to move on! This is looking pretty good. ❤️ Some minor things to address:
If you will enable the |
|
Sorry, the
|
|
I've run black 23.3.0 (latest), added Python 3.11 to the CI checks and updated the .md files. Note that I mentioned the wrong version of black in my commit ... it was the version of Pip, which is also 23.x. |
Huh. Weird. Do you see it in a place more like this?
|
That's really odd, because you're commit has lots of whitespace changes that are showing up as new linting errors, and when I run black locally, it reverts your changes. Do you, perhaps, have some different black configuration in your local environment or something? |
Co-authored-by: Nathan Stocks <cleancut@github.com>
Co-authored-by: Nathan Stocks <cleancut@github.com>
``` docker run -it --entrypoint=/bin/bash -v $(pwd):/green python:3.11 root@bdf5d7007526:/# cd green/ root@bdf5d7007526:/green# pip install black root@bdf5d7007526:/green# black green root@bdf5d7007526:/green# black example ```
|
Sorry, I really cannot find the checkbox to allow edits anywhere. The fork is tied to our work Org and might not give the option somehow. I've added your suggestions to the PR. As for black, I re-ran it from a vanilla image to remove the possibility of an other config on my machine. I hope this time it will be better. We usually run |
|
@CleanCut is there anything else you want me to change here? |
|
Sorry for the delay, I was away for several days. 😄 This looks great! |
Tested with
green greenwith python 3.6 (some of the test code uses f-strings so we cannot test with python 3.5).