Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy to the linting step. #271

Merged
merged 3 commits into from
May 18, 2023
Merged

Add mypy to the linting step. #271

merged 3 commits into from
May 18, 2023

Conversation

sodul
Copy link
Collaborator

@sodul sodul commented May 9, 2023

Address mypy issues.
Add CONTRIBUTING.md file.

Address mypy issues.
Add CONTRIBUTING.md file.
@sodul
Copy link
Collaborator Author

sodul commented May 9, 2023

Tests are failing in CI, I'll reproduce locally and will fix.

@sodul
Copy link
Collaborator Author

sodul commented May 9, 2023

For some reason the Ci check for Windows/Py36 got stuck and is still in progress after several hours. I cannot abort it, maybe you can: https://github.com/CleanCut/green/actions/runs/4921522632

To avoid this issue I added a timeout for the CI check. I've added workflow_dispatch so that I could run the checks more easily, on demand, from our fork without having to run it from your side.

Add 15m timeout to CI checks.
Update CI checks to pip install green in developer mode.
@sodul
Copy link
Collaborator Author

sodul commented May 9, 2023

The issue with the windows CI check is that I added a tearDown to test_integration.py to cleanup the temp directory. On Windows with Python 3.6 an other process is accessing the same folder somehow, although it is supposed to be a unique folder.
The fix was to ignore errors when calling rmtree, and make it a best effort deletion.

Note that the macOS Py 3.11 check is taking 4-6m to pip install and it seems to be because it needs to compile lxml from source as a universal binary.

@CleanCut let me know if you have any issues with the PR.

Copy link
Owner

@CleanCut CleanCut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making good progress. 😄

.github/workflows/ci.yml Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
green/test/test_integration.py Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
green/command.py Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Nathan Stocks <cleancut@github.com>
@sodul
Copy link
Collaborator Author

sodul commented May 10, 2023

@CleanCut There is an ongoing GitHub incident with Actions being impacted. It has been very unstable this week with 3 separate incidents just yesterday.

https://www.githubstatus.com

Feel free to restart the check once the incidents are over, you have more details on this than I do ;-)

@sodul
Copy link
Collaborator Author

sodul commented May 18, 2023

@CleanCut sorry to nag you, but is there anything else you need me to update here?

Copy link
Owner

@CleanCut CleanCut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@CleanCut CleanCut merged commit ff8d950 into CleanCut:main May 18, 2023
@sodul sodul deleted the mypy branch January 25, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants