Improve support for local testing. #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add dev dependencies to setup.cfg through requirements-dev.txt, to simpl - Add support to test python versions locally with docker.
sodul
commented
Jan 22, 2024
| @make test-installed | ||
| make test-versions | ||
| make test-coverage | ||
| @# test-coverage needs to be last in deps, don't clean after it runs! | ||
|
|
||
| test-on-containers: clean-silent | ||
| @# Run the tests on pristine containers to isolate us from the local environment. | ||
| @for version in 3.8 3.9 3.10 3.11 3.12.0; do \ |
There was a problem hiding this comment.
I specify 3.12.0 for now as we are still incompatible with 3.12.1. I want to make testing easier before pushing the compatibility fixes for 3.12.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve setup.cfg to perform local dev installs more simply and add a make target that uses vanilla python containers of supported versions for local development.
The new
make test-on-containersruns under 2m on a M1 Pro machine and runs our tests against python 3.8, 3.9, 3.10, 3.11 and 3.12.0.