Cleanup dead code and fix some imports. #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes code that was here for older versions of python that we no longer support. Unused imports have been removed while missing ones have been added.
sodul
commented
Jan 25, 2024
| @@ -441,7 +441,7 @@ def parseArguments(argv=None): # pragma: no cover | |||
| ), | |||
| default=argparse.SUPPRESS, | |||
| ) | |||
| ), | |||
There was a problem hiding this comment.
This made a tuple declaration serving no purpose.
sodul
commented
Jan 25, 2024
| import sys | ||
| import unittest | ||
| from configparser import ConfigParser | ||
| from unittest.mock import patch, MagicMock, call |
There was a problem hiding this comment.
These new imports are actually used which makes me feel that this part of the test code is not actually being run.
sodul
commented
Jan 25, 2024
| """ | ||
| try: | ||
| import coverage | ||
| except ImportError: | ||
| self.skipTest("Coverage needs to be installed for this test") | ||
| self.assertTrue(coverage.version_info) |
There was a problem hiding this comment.
This double up as a way to 'use' coverage so linters do not complained about unused imports.
IanFoertsch-clumio
approved these changes
Jan 25, 2024
| @@ -737,14 +735,6 @@ def printErrors(self): | |||
| if not self.args.no_tracebacks: | |||
| relevant_frames = [] | |||
| for i, frame in enumerate(err.traceback_lines): | |||
| # Python2 tracebacks containing unicode need some special handling | |||
There was a problem hiding this comment.
I can see the minimum python version is now 3.8, so this make sense 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes code that was here for older versions of python that we no longer support. Unused imports have been removed while missing ones have been added.