Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set environment name for the releases #291

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Set environment name for the releases #291

merged 2 commits into from
Feb 15, 2024

Conversation

sodul
Copy link
Collaborator

@sodul sodul commented Feb 15, 2024

The 'deployment' environments are required to match in the actions.

Validated with the release-test environment which did publish from the action of the official repo.

Once this is merged to main we should be able release 100% from the GH UI.

https://test.pypi.org/project/green/4.0.1/

Released through:
https://github.com/CleanCut/green/actions/runs/7912354962/job/21597969386

Checking dist/green-4.0.1.tar.gz: PASSED
Uploading distributions to https://test.pypi.org/legacy/
Uploading green-4.0.1.tar.gz
25l
[ .. snip .. ]
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 85.7/85.7 kB • 00:00 • 183.2 MB/s
25h
View at:
https://test.pypi.org/project/green/4.0.1/

@coveralls
Copy link

Coverage Status

coverage: 0.0%. remained the same
when pulling cf1b1de on release-env
into b34629f on main.

@sodul
Copy link
Collaborator Author

sodul commented Feb 15, 2024

@CleanCut sorry it needs an other PR this was the first time for me to work with PyPi releases from GH, and using the concept of Environments in Actions so I did not grasp their implication. The test release to test.pypi.org does confirm that everything is now working as intended.

Copy link
Collaborator

@IanFoertsch-clumio IanFoertsch-clumio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sodul sodul merged commit 9e9e5cf into main Feb 15, 2024
24 checks passed
@sodul sodul deleted the release-env branch February 15, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants