Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclusion by domain or in global expections #353

Open
kallookoo opened this issue Mar 10, 2024 · 5 comments
Open

Add exclusion by domain or in global expections #353

kallookoo opened this issue Mar 10, 2024 · 5 comments

Comments

@kallookoo
Copy link

Hello,

I really like this extension, but not being able to control the exceptions is a problem because depending on the type of user, you might want to exclude a domain or a rule for development reasons, government websites, etc ... instead of having to disable the extension.

An example could be my case when I visit a government website in Spain that uses "GA_*" parameters that are not related to Google, causing it to not be able to log in.

Obviously it could create an issue, but if we think in global terms the size of the json will end up having a bigger size to satisfy all the demands.

So I was wondering if you could consider including custom exceptions.

I attach also the log, so you can see my problem in question.

Thanks

ClearURLsLogExport.json

@KMohZaid
Copy link

It is possible to implement. I may try to add if gets time

@tsilvs
Copy link

tsilvs commented Sep 12, 2024

Any progress on this feature?

@KMohZaid
Copy link

sorry, i am unable to any contribution due to my project and other situation

@kallookoo can you tell what kind of exclusion you want? like domain name and regex domain name
i will implement it when i get time to do, so if i get to know what kind of feature you think of. i may can save time and do it early

@kallookoo
Copy link
Author

I think a field in the options page to exclude a domain from filtering would be sufficient and to support subdomains you could use regex. I consider it to be the simplest way to maintain and easy to configure for all who use the extension.

So first you would check that the (sub)domain is not defined and then filter the url. What we usually call a whilelist.

@KMohZaid
Copy link

@kallookoo @tsilvs so i did it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants