Allow TMPDIR for tests

[wolfgangwalther]

On NixOS, /tmp is not writeable and TMPDIR is set. Use that instead.

Failure log without this patch: https://hydra.nixos.org/build/275642339/nixlog/1

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.51%. Comparing base (8a80fba) to head (68526a3).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #810   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files          20       20           
  Lines         889      890    +1     
=======================================
+ Hits          858      859    +1     
  Misses         31       31           

Flag	Coverage Δ
unittests	96.51% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fizyk]

@wolfgangwalther is there a way to include nixos in the CI on github-actions? And the other thing, could you add newsfragment?

[wolfgangwalther]

is there a way to include nixos in the CI on github-actions?

That would be possible, sure, but I don't have the bandwidth to do that, sorry.

And the other thing, could you add newsfragment?

Not sure what I would write in a changelog about such a technical change in the tests. Nothing, probably.

[wolfgangwalther]

And the other thing, could you add newsfragment?

Hm, I can't find any template or anything on how those newsfragments should look like. I have never used towncrier (?).

[wolfgangwalther]

And the other thing, could you add newsfragment?

Hm, I can't find any template or anything on how those newsfragments should look like. I have never used towncrier (?).

Ah, found some in the git history. Like this?

[fizyk]

And the other thing, could you add newsfragment?

Hm, I can't find any template or anything on how those newsfragments should look like. I have never used towncrier (?).

The chore in pr template shows the command to run to get a newsfragment :)

And yes, something like this.

And as for the test, no worries, hopefully I won't break anything in the future there ;)

Question though, why you need to run mirakuru's tests on NixOS? Outside of it's CI?

[wolfgangwalther]

Question though, why you need to run mirakuru's tests on NixOS? Outside of it's CI?

In NixOS we try to always run all packages' tests when building them. I think most distributions do the same.

[fizyk]

I'll have to remeber to switch to https://docs.pytest.org/en/stable/how-to/tmp_path.html in the future.

[fizyk]

Switched to tmp_path_factory #846