fix Eugeny#8534 : skip yaml unacceptable kind of object to dump

Clem-Fern · Jul 7, 2023 · 82a2620 · 82a2620
1 parent 6709217
commit 82a2620
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/tabby-core/src/services/config.service.ts b/tabby-core/src/services/config.service.ts
@@ -205,15 +205,15 @@ export class ConfigService {
         // Scrub undefined values
         let cleanStore = JSON.parse(JSON.stringify(this._store))
         cleanStore = await this.maybeEncryptConfig(cleanStore)
-        await this.platform.saveConfig(yaml.dump(cleanStore))
+        await this.platform.saveConfig(yaml.dump(cleanStore, {skipInvalid: true}))
         this.emitChange()
     }
 
     /**
      * Reads config YAML as string
      */
     readRaw (): string {
-        return yaml.dump(this._store)
+        return yaml.dump(this._store, {skipInvalid: true})
     }
 
     /**

diff --git a/tabby-settings/src/services/configSync.service.ts b/tabby-settings/src/services/configSync.service.ts
@@ -97,7 +97,7 @@ export class ConfigSyncService {
                     data[part] = remoteData[part]
                 }
             }
-            const content = yaml.dump(data)
+            const content = yaml.dump(data, {skipInvalid: true})
             const result = await this.updateConfig(this.config.store.configSync.configID, {
                 content,
                 last_used_with_version: this.platform.getAppVersion(),
@@ -154,7 +154,7 @@ export class ConfigSyncService {
     }
 
     private async writeConfigDataFromSync (data: any) {
-        await this.platform.saveConfig(yaml.dump(data))
+        await this.platform.saveConfig(yaml.dump(data, {skipInvalid: true}))
         await this.config.load()
         await this.config.save()
     }