-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/RPM + sensor thresholds + fancy sensors #149
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apehaenger
changed the title
Feature/RPM + thresholds for fancy sensors
Feature/RPM + sensor thresholds + fancy sensors
Sep 17, 2024
rovo89
reviewed
Sep 18, 2024
rovo89
reviewed
Sep 18, 2024
rovo89
reviewed
Sep 18, 2024
rovo89
reviewed
Sep 18, 2024
rovo89
reviewed
Sep 18, 2024
rovo89
reviewed
Sep 18, 2024
rovo89
reviewed
Sep 18, 2024
set_sensor_limits(sc_pair.second); | ||
sc_pair.second.si_pub.publish(sc_pair.second.si); | ||
} | ||
registerSensors(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
registerSensors()
seems to do much more than the previous code. Maybe introduce a parameter to call a "lite" version of it?
…n direction indication)
olliewalsh
reviewed
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like to see "normal" RPMs.
Mainly for the mower-motor because this is the one of interest... but for sure, as we've a common code-base for all ESC's, it will be published also for the drive ESCs.
State of ESCs:
Required submodule PRs:
For sure, I also plan to add the RPMs into WebApp, but not sure at the moment when ;-)Also not to forget:
The next (dry) days I'll test it in real on my ubuntu mower where I'm able to compile, and once the build-image CI work again, I can test the compiled image on the other one, which happily also has some other ESC config.