Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: on Linux, check coretemp and don't fail fast with name generation when gathering temps #1188

Merged
merged 18 commits into from
Jun 11, 2023

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Jun 8, 2023

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Issue

If applicable, what issue does this address?

Closes: #1185

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang force-pushed the linux_temps_check_sys_devices branch from a00f29e to b298135 Compare June 8, 2023 04:13
@ClementTsang ClementTsang changed the title bug: also check coretemp on Linux when gathering temps feature: also check coretemp on Linux when gathering temps Jun 8, 2023
@ClementTsang ClementTsang marked this pull request as ready for review June 8, 2023 04:13
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 36.25% and project coverage change: +0.31 🎉

Comparison is base (e602cc7) 31.29% compared to head (fe1d99c) 31.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1188      +/-   ##
==========================================
+ Coverage   31.29%   31.60%   +0.31%     
==========================================
  Files          97       97              
  Lines       16385    16511     +126     
==========================================
+ Hits         5127     5218      +91     
- Misses      11258    11293      +35     
Flag Coverage Δ
macos-12 33.16% <0.00%> (ø)
ubuntu-latest 33.17% <36.25%> (+0.31%) ⬆️
windows-2019 33.42% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/data_harvester/temperature/nvidia.rs 0.00% <0.00%> (ø)
src/app/data_harvester/temperature/linux.rs 33.45% <36.54%> (+33.45%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ClementTsang ClementTsang force-pushed the linux_temps_check_sys_devices branch 2 times, most recently from 0c7c9b2 to 8dc523c Compare June 9, 2023 22:59
@ClementTsang ClementTsang changed the title feature: also check coretemp on Linux when gathering temps feature: check coretemp on Linux when gathering temps and don't fail fast with name generation Jun 11, 2023
@ClementTsang ClementTsang changed the title feature: check coretemp on Linux when gathering temps and don't fail fast with name generation feature: on Linux, check coretemp and don't fail fast with name generation when gathering temps Jun 11, 2023
@ClementTsang ClementTsang force-pushed the linux_temps_check_sys_devices branch from cf10591 to 7e4b49c Compare June 11, 2023 21:41
@ClementTsang ClementTsang force-pushed the linux_temps_check_sys_devices branch from 7e4b49c to fe1d99c Compare June 11, 2023 22:03
@ClementTsang ClementTsang merged commit 9560722 into master Jun 11, 2023
@ClementTsang ClementTsang deleted the linux_temps_check_sys_devices branch June 11, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant