-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: on Linux, check coretemp and don't fail fast with name generation when gathering temps #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementTsang
force-pushed
the
linux_temps_check_sys_devices
branch
from
June 8, 2023 04:13
a00f29e
to
b298135
Compare
ClementTsang
changed the title
bug: also check coretemp on Linux when gathering temps
feature: also check coretemp on Linux when gathering temps
Jun 8, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1188 +/- ##
==========================================
+ Coverage 31.29% 31.60% +0.31%
==========================================
Files 97 97
Lines 16385 16511 +126
==========================================
+ Hits 5127 5218 +91
- Misses 11258 11293 +35
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ClementTsang
force-pushed
the
linux_temps_check_sys_devices
branch
2 times, most recently
from
June 9, 2023 22:59
0c7c9b2
to
8dc523c
Compare
ClementTsang
changed the title
feature: also check coretemp on Linux when gathering temps
feature: check coretemp on Linux when gathering temps and don't fail fast with name generation
Jun 11, 2023
ClementTsang
changed the title
feature: check coretemp on Linux when gathering temps and don't fail fast with name generation
feature: on Linux, check coretemp and don't fail fast with name generation when gathering temps
Jun 11, 2023
This reverts commit 402606c.
ClementTsang
force-pushed
the
linux_temps_check_sys_devices
branch
from
June 11, 2023 21:41
cf10591
to
7e4b49c
Compare
ClementTsang
force-pushed
the
linux_temps_check_sys_devices
branch
from
June 11, 2023 22:03
7e4b49c
to
fe1d99c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:
Issue
If applicable, what issue does this address?
Closes: #1185
Testing
If relevant, please state how this was tested. All changes must be tested to work:
If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt
)README.md
, help menu, doc pages, etc.)