Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ntfs3 mounts don't show up #1191

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

database64128
Copy link
Contributor

Description

Match ntfs3 as NTFS. I didn't use eq_ignore_ascii_case because it's specific to Linux and the letters won't be uppercase.

Issue

Partitions mounted using the ntfs3 driver in linux (mainlined since 5.15) won't show up because the name didn't match.

Here's the relevant line in /proc/mounts:

/dev/sdb2 /mnt/hdd_4t ntfs3 rw,noatime,uid=0,gid=0,iocharset=utf8 0 0

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Partitions mounted using the ntfs3 driver in linux (mainlined since 5.15)
won't show up because the name didn't match.
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1cc0e91) 30.99% compared to head (db5f756) 30.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1191   +/-   ##
=======================================
  Coverage   30.99%   30.99%           
=======================================
  Files          96       96           
  Lines       16541    16541           
=======================================
  Hits         5127     5127           
  Misses      11414    11414           
Flag Coverage Δ
macos-12 33.00% <0.00%> (ø)
ubuntu-latest 32.53% <0.00%> (ø)
windows-2019 33.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/data_harvester/disks/unix/file_systems.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@ClementTsang ClementTsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching this. Will merge in a bit.

@ClementTsang ClementTsang merged commit 48422c4 into ClementTsang:master Jun 8, 2023
@database64128 database64128 deleted the filesystem-ntfs3 branch June 8, 2023 18:36
ClementTsang added a commit that referenced this pull request Jun 8, 2023
ClementTsang added a commit that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants