Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: pin serde to 1.0.188 #1286

Merged
merged 2 commits into from
Aug 27, 2023
Merged

deps: pin serde to 1.0.188 #1286

merged 2 commits into from
Aug 27, 2023

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Aug 26, 2023

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Issue

If applicable, what issue does this address?

Closes: #1285

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3e00e65) 31.64% compared to head (69c9858) 31.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1286   +/-   ##
=======================================
  Coverage   31.64%   31.64%           
=======================================
  Files          98       98           
  Lines       16644    16644           
=======================================
  Hits         5267     5267           
  Misses      11377    11377           
Flag Coverage Δ
macos-12 33.37% <ø> (ø)
ubuntu-latest 33.20% <ø> (ø)
windows-2019 33.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang force-pushed the pin_serde_1.0.188 branch 4 times, most recently from 3b7364d to 3f0bbbb Compare August 27, 2023 00:03
@ClementTsang ClementTsang merged commit 11676bb into master Aug 27, 2023
33 checks passed
@ClementTsang ClementTsang deleted the pin_serde_1.0.188 branch August 27, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation fails without --locked
1 participant