Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fixed un-inlined args #1310

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Oct 10, 2023

Description

First ran this, and fixed a few more similar issues by hand

cargo clippy --workspace --fix --benches --tests --bins -- -A clippy::all -W clippy::uninlined_format_args

Note that in a few cases, format args were passed by ref - which is actually a tiny perf hit - compiler would not be able to optimize them.

First ran this, and fixed a few more similar issues by hand

```
cargo clippy --workspace --fix --benches --tests --bins -- -A clippy::all -W clippy::uninlined_format_args
```

Note that in a few cases, format args were passed by ref - which is actually a tiny perf hit - compiler would not be able to optimize them.
@nyurik nyurik changed the title Fixed uninlined args Chore: Fixed un-inlined args Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (a620064) 31.64% compared to head (ccbfebe) 31.63%.

Files Patch % Lines
src/utils/gen_util.rs 0.00% 8 Missing ⚠️
src/app/query.rs 0.00% 5 Missing ⚠️
src/canvas/widgets/mem_graph.rs 0.00% 4 Missing ⚠️
src/canvas/widgets/network_basic.rs 0.00% 4 Missing ⚠️
src/app/process_killer.rs 0.00% 2 Missing ⚠️
src/canvas/widgets/basic_table_arrows.rs 0.00% 2 Missing ⚠️
src/canvas/widgets/battery_display.rs 0.00% 2 Missing ⚠️
src/canvas/widgets/network_graph.rs 0.00% 2 Missing ⚠️
src/widgets/disk_table.rs 0.00% 2 Missing ⚠️
src/app/data_harvester/processes/linux.rs 0.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1310      +/-   ##
==========================================
- Coverage   31.64%   31.63%   -0.01%     
==========================================
  Files          98       98              
  Lines       16640    16629      -11     
==========================================
- Hits         5265     5261       -4     
+ Misses      11375    11368       -7     
Flag Coverage Δ
macos-12 33.36% <14.28%> (-0.01%) ⬇️
ubuntu-latest 33.20% <15.90%> (-0.01%) ⬇️
windows-2019 33.62% <15.38%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

since it contains a non-inlineable variable I'm not a fan of using it partially here
given the other formats above/below I would prefer keeping it like this
Copy link
Owner

@ClementTsang ClementTsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks fine to me, made some small changes for personal style reasons.

@ClementTsang ClementTsang merged commit 5eb4fbd into ClementTsang:master Nov 15, 2023
33 checks passed
@nyurik nyurik deleted the inline-fmt branch July 31, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants