Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fat32 mounts don't show up in macOS #1314

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

Devin-Yeung
Copy link
Contributor

Description

Match msdos (fat32) as vfat

Issue

Partitions mounted using the fat32(msdos) driver in macOS (Sonoma 14.0) won't show up because the name didn't match.

Relevant information provided by diskutil list

/dev/disk4 (external, physical):
   #:                       TYPE NAME                    SIZE       IDENTIFIER
   0:     FDisk_partition_scheme                        *123.0 GB   disk4
   1:             Windows_FAT_32 SANDISK                 123.0 GB   disk4s1

Testing

If relevant, please state how this was tested. All changes must be tested to work:

Manually check on macOS (Sonoma)

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (712a003) 31.64% compared to head (9018fae) 31.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1314      +/-   ##
==========================================
- Coverage   31.64%   31.64%   -0.01%     
==========================================
  Files          98       98              
  Lines       16639    16640       +1     
==========================================
  Hits         5265     5265              
- Misses      11374    11375       +1     
Flag Coverage Δ
macos-12 33.36% <0.00%> (-0.01%) ⬇️
ubuntu-latest 33.20% <0.00%> (-0.01%) ⬇️
windows-2019 33.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/app/data_harvester/disks/unix/file_systems.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang
Copy link
Owner

Thanks for this, will take a look in a bit.

@ClementTsang ClementTsang merged commit d1d1498 into ClementTsang:master Nov 15, 2023
@Devin-Yeung Devin-Yeung deleted the macos-fat32 branch November 15, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants