Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ratatui version #1362

Merged
merged 3 commits into from
Dec 25, 2023
Merged

update ratatui version #1362

merged 3 commits into from
Dec 25, 2023

Conversation

jamartin9
Copy link
Contributor

@jamartin9 jamartin9 commented Dec 23, 2023

Description

Update ratatui to version 0.25.0 (api changes: moved the Backend type, moved widths to new and added a Marker for half block)
Use convert_mem_label instead of convert_arc_labels

Testing

Ran on linux with arc enabled.

  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Feel free to close if the dependency should remained pinned.

Copy link

codecov bot commented Dec 23, 2023

Codecov Report

Attention: 81 lines in your changes are missing coverage. Please review.

Comparison is base (a1168ca) 32.37% compared to head (de16c72) 33.08%.

Files Patch % Lines
src/components/data_table/draw.rs 0.00% 23 Missing ⚠️
src/canvas/widgets/network_graph.rs 0.00% 17 Missing ⚠️
src/canvas/widgets/battery_display.rs 0.00% 10 Missing ⚠️
src/canvas/widgets/process_table.rs 0.00% 6 Missing ⚠️
src/canvas.rs 0.00% 3 Missing ⚠️
src/canvas/widgets/cpu_graph.rs 0.00% 3 Missing ⚠️
src/components/tui_widget/time_chart/canvas.rs 0.00% 3 Missing ⚠️
src/bin/main.rs 0.00% 2 Missing ⚠️
src/canvas/dialogs/dd_dialog.rs 0.00% 2 Missing ⚠️
src/canvas/widgets/cpu_basic.rs 0.00% 2 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1362      +/-   ##
==========================================
+ Coverage   32.37%   33.08%   +0.71%     
==========================================
  Files          98       94       -4     
  Lines       17167    16770     -397     
==========================================
- Hits         5557     5549       -8     
+ Misses      11610    11221     -389     
Flag Coverage Δ
macos-12 34.26% <0.00%> (+0.05%) ⬆️
ubuntu-latest 34.01% <0.00%> (+0.05%) ⬆️
windows-2019 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/canvas/widgets/network_basic.rs Outdated Show resolved Hide resolved
@ClementTsang ClementTsang merged commit 28d2950 into ClementTsang:main Dec 25, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants