-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to set a position of legend #1430
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1430 +/- ##
==========================================
+ Coverage 55.84% 55.90% +0.05%
==========================================
Files 97 97
Lines 18183 18271 +88
==========================================
+ Hits 10154 10214 +60
- Misses 8029 8057 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long - generally looks fine, left some small things to change/look at but otherwise should be good. Thanks for the PR!
fb4d315
to
2f9d17b
Compare
I apply suggentions and rebase to one commit. |
Could you rerun CI? I don't know why CI failed on macOS tests. |
Seems like it timed out for some reason. Also sorry for the delay, I'll take a look at the changes in a bit. |
Made some small changes but otherwise looks good - thanks again for doing this! @all-contributors please add @lyuha for code, docs |
I couldn't determine any contributions to add, did you specify any contributions? I've put up a pull request to add @lyuha! 🎉 |
Description
Add options and args to change a position of time_chart's legend.
Issue
Related issues: #1125
Testing
If relevant, please state how this was tested. All changes must be tested to work:
If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt
)README.md
, help menu, doc pages, etc.)