Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: change how disk, temp, and net filters in config are set #1481

Merged
merged 3 commits into from
Jun 16, 2024

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Jun 16, 2024

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Change how the disk, temp, and net filters are set in the config file by moving to a more generalized "per-widget" config.

I'll update the json schema later (going to probably set it up to update automatically).

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Jun 16, 2024

Codecov Report

Attention: Patch coverage is 34.05172% with 153 lines in your changes missing coverage. Please review.

Project coverage is 40.86%. Comparing base (46520d8) to head (16773df).

Files Patch % Lines
.../canvas/components/tui_widget/time_chart/canvas.rs 0.00% 21 Missing ⚠️
src/app/query.rs 0.00% 15 Missing ⚠️
src/app.rs 0.00% 13 Missing ⚠️
src/options.rs 60.60% 13 Missing ⚠️
src/data_collection/temperature/linux.rs 0.00% 12 Missing ⚠️
src/canvas/dialogs/dd_dialog.rs 0.00% 8 Missing ⚠️
src/data_collection/disks/unix.rs 0.00% 8 Missing ⚠️
src/widgets/cpu_graph.rs 0.00% 6 Missing ⚠️
...ta_collection/disks/unix/macos/io_kit/io_object.rs 0.00% 5 Missing ⚠️
src/app/states.rs 0.00% 4 Missing ⚠️
... and 22 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1481      +/-   ##
==========================================
- Coverage   40.98%   40.86%   -0.13%     
==========================================
  Files          99      102       +3     
  Lines       17459    17525      +66     
==========================================
+ Hits         7156     7162       +6     
- Misses      10303    10363      +60     
Flag Coverage Δ
macos-12 36.21% <29.12%> (-0.13%) ⬇️
ubuntu-latest 42.82% <36.74%> (-0.12%) ⬇️
windows-2019 36.35% <28.49%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang merged commit 982b718 into main Jun 16, 2024
36 checks passed
@ClementTsang ClementTsang deleted the rearrange_widget_specific_config branch June 16, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant