Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybindings "Reload Item" and "Reload Wielded Item" do the same thing #36297

Closed
CoroNaut opened this issue Dec 20, 2019 · 2 comments · Fixed by #36658
Closed

Keybindings "Reload Item" and "Reload Wielded Item" do the same thing #36297

CoroNaut opened this issue Dec 20, 2019 · 2 comments · Fixed by #36658
Labels
Controls / Input Keyboard, mouse, keybindings, input UI, etc. Items / Item Actions / Item Qualities Items and how they work and interact

Comments

@CoroNaut
Copy link

CoroNaut commented Dec 20, 2019

Describe the bug

The keybindings "Reload item" and "Reload Wielded item" both go to the same menu with tailoring kit, the reload item menu.

Steps To Reproduce

  1. Make keybindings for both reload item and reload wielded item
  2. Notice they both lead to same menu

Expected behavior

Reload wielded item should try to immediately reload wielded item

Versions and configuration

  • OS: Windows
    • OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
  • Game Version: 0.D-10211-g0bd1ad2 [64-bit]
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda]
    ]
@Night-Pryanik Night-Pryanik added Controls / Input Keyboard, mouse, keybindings, input UI, etc. Items / Item Actions / Item Qualities Items and how they work and interact labels Dec 20, 2019
@Ramza13
Copy link
Contributor

Ramza13 commented Dec 31, 2019

So if reload wielded object fails to find any wielded object or weapon or magazine in your inventory it will then call reload item and pop up the menu to allow you to reload something else. This seems intentional so you don't need to map both keys.

Heres the description of the reload wielded item(which under the hood is called reload weapons because that's really what it does first even if they aren't wielded)

Cataclysm-DDA/src/game.cpp

Lines 8482 to 8488 in b1541cd

// As a special streamlined activity, hitting reload repeatedly should:
// Reload wielded gun
// First reload a magazine if necessary.
// Then load said magazine into gun.
// Reload magazines that are compatible with the current gun.
// Reload other guns in inventory.
// Reload misc magazines in inventory.

@CoroNaut
Copy link
Author

CoroNaut commented Jan 1, 2020

So is this feature only meant for weapons with magazines and ammuntion and not items like tailoring kit? I would much prefer to be able to reload the tailoring kit with the "reload wielded item" rather than having to use the "reload item" menu for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Controls / Input Keyboard, mouse, keybindings, input UI, etc. Items / Item Actions / Item Qualities Items and how they work and interact
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants