Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatability.h needs review #36370

Closed
NooneAtAll opened this issue Dec 23, 2019 · 2 comments · Fixed by #47536
Closed

compatability.h needs review #36370

NooneAtAll opened this issue Dec 23, 2019 · 2 comments · Fixed by #47536
Labels
Code: Build Issues regarding different builds and build environments

Comments

@NooneAtAll
Copy link

NooneAtAll commented Dec 23, 2019

Is your feature request related to a problem? Please describe.

"compatability.h" is a file made to fix GCC compiler versions
before 4.8 due to flag (MinGW) and newlib (Cygwin) issues
(std::to_string was not provided)

As current minimal GCC version supported is 5.3, most code
in the file regarding MinGW is not used.

After extensive googling I have found several mentions of
CygWin not giving the error with -std=c++11 and -std=c++14
flags. (later of which is what is used in this codebase)

Describe the solution you'd like

Some testing needed whether whole file, parts of it or at least Cygwin build
flag can be deleted.

@KorGgenT KorGgenT added the Code: Build Issues regarding different builds and build environments label Dec 23, 2019
@stale
Copy link

stale bot commented Jan 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Jan 22, 2020
@stale
Copy link

stale bot commented Feb 21, 2020

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it

@stale stale bot closed this as completed Feb 21, 2020
@BrettDong BrettDong removed the stale Closed for lack of activity, but still valid. label Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Build Issues regarding different builds and build environments
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants