Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-repaired vehicle frames with no cost #36513

Closed
NeevAsteria opened this issue Dec 28, 2019 · 1 comment · Fixed by #60762
Closed

Auto-repaired vehicle frames with no cost #36513

NeevAsteria opened this issue Dec 28, 2019 · 1 comment · Fixed by #60762
Labels
<Bug> This needs to be fixed Vehicles Vehicles, parts, mechanics & interactions

Comments

@NeevAsteria
Copy link
Contributor

Describe the bug

When using damaged vehicle frames and using the 'Start Vehicle Construction', the frame is automatically repaired to full health without any cost or effort.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Acquire a damaged vehicle frame
  2. Open construction menu and select "Start Vehicle Construction"
  3. Make sure to use the damaged vehicle frame
  4. Examine vehicle to check the health of the frame

Expected behavior

The vehicle frame should reflect the health of the frame when making a new vehicle, similar to when using a damaged frame to install on an existing vehicle.

Screenshots

Test
Test2
test3

Versions and configuration

  • OS: Windows 8.1
  • Game Version: 0.D-10735-gd146e46
  • Graphics version: Tiles
  • Mods loaded:
    modlist

Additional context

Deconstructing the magically repaired frame gives a full health frame.

@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Vehicles Vehicles, parts, mechanics & interactions labels Jan 5, 2020
@kevingranade
Copy link
Member

It looks like the problem is that with a normal part installation the part used as the base is literally copied into place inside the vehicle part, but for some reason when creating a new vehicle, it instead only stores the "kind" of vehicle part, and it inserts an entirely new instance of that type into the vehicle part as it's being constructed.

This is happening in construct::done_vehicle() in construction.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants