Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Item_factory to use generic_factory #36851

Open
KorGgenT opened this issue Jan 9, 2020 · 0 comments
Open

Rework Item_factory to use generic_factory #36851

KorGgenT opened this issue Jan 9, 2020 · 0 comments
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style (P5 - Long-term) Long-term WIP, may stay on the list for a while.

Comments

@KorGgenT
Copy link
Member

KorGgenT commented Jan 9, 2020

Is your feature request related to a problem? Please describe.
Item_factory is a specialized class that was written before the implementation of generic_factory. As such, it does not take advantage of some of the newer features of that. In addition, it is a little bit more difficult to see what's going on since it doesn't follow the same implementation as much of the rest of our json loading.
Describe the solution you'd like
Reimplement Item_factory as a generic_factory. There is plenty of documentation on generic_factory in generic_factory.h, it is quite straightforward to use and it does not necessarily require understanding on the underlying template functions.

@KorGgenT KorGgenT added [C++] Changes (can be) made in C++. Previously named `Code` (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Jan 9, 2020
@KorGgenT KorGgenT added this to the 0.F milestone Jan 9, 2020
@ZhilkinSerg ZhilkinSerg added (P5 - Long-term) Long-term WIP, may stay on the list for a while. and removed (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter labels Jan 10, 2020
@KorGgenT KorGgenT removed this from the 0.F milestone Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style (P5 - Long-term) Long-term WIP, may stay on the list for a while.
Projects
None yet
Development

No branches or pull requests

2 participants