Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPC's strength too low to use its starting weapon #40058

Closed
mon-pad opened this issue May 1, 2020 · 3 comments · Fixed by #46440
Closed

NPC's strength too low to use its starting weapon #40058

mon-pad opened this issue May 1, 2020 · 3 comments · Fixed by #46440
Labels
<Bug> This needs to be fixed NPC / Factions NPCs, AI, Speech, Factions, Ownership
Milestone

Comments

@mon-pad
Copy link
Contributor

mon-pad commented May 1, 2020

Describe the bug

An NPC follower has 7 base strength, but the default weapon it was equipped with was a crossbow, requiring 8 strength to use. Despite being unable to use it, when trying to give them a worse weapon it says "My current weapon is better than this".

Steps To Reproduce

Expected behavior

Either for an NPC's default weapon to be one it is capable of using, or for them to accept a worse weapon on the condition that they cannot use their current weapon.

Screenshots

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1809
  • Game Version: 0.E-1404-g1268e85 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Monsters [No_Fungi]
    ]

Additional context

@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed NPC / Factions NPCs, AI, Speech, Factions, Ownership labels May 2, 2020
@natsirt721
Copy link
Contributor

I've seen this happen with crossbow-wielding bandits too. Makes some of the early bandit-hunting missions very easy when they can't even shoot back.

@inverimus
Copy link
Contributor

This happens quite frequently with the starting NPC having a crossbow and low strength so they can't use it. They also refuse all other weapons that are not better than a crossbow and will continue to wield the crossbow and use it in melee when told not to use ranged weapons.

@kevingranade kevingranade added this to the 0.F milestone Dec 17, 2020
@actual-nh
Copy link
Contributor

Would weapon_value (in melee.cpp - does both guns and melee weapons) checking meets_stat_requirements (in character.cpp), and returning 0.0 value for not meeting this, fix this for followers, at least? Or is there something more complex than that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants