Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempted to fire zero or negative shots #42889

Closed
BQurious opened this issue Aug 12, 2020 · 3 comments
Closed

Attempted to fire zero or negative shots #42889

BQurious opened this issue Aug 12, 2020 · 3 comments

Comments

@BQurious
Copy link
Contributor

BQurious commented Aug 12, 2020

Describe the bug

Related: #42121
Error when attempting to fire a weapon

DEBUG : Attempted to fire zero or negative shots using <color_c_green>++ coilgun+6

FUNCTION : int player::fire_gun(const tripoint&, int, item&)
FILE : src/ranged.cpp
LINE : 435

Steps To Reproduce

Unable to reproduce with fresh character/item/etc, repeatable with attached save file (just fire held weapon). Potentially (un)related actions leading up to the error are:

  1. Attached bayonet (to a coilgun in this case)
  2. Fired gun at mobs several times without issue
  3. Dropped gun to switch to other weapon
  4. Left it there for about a day
  5. Came back, picked it up, tried to fire it
  6. No shots fired

Expected behavior

Shots fired

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1909
  • Game Version: 0.E-2 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food]
    ]

Additional context

Save file:
Maili.zip

Log file:
debug.log

May be worth noting that multiple other (probably unrelated) errors occurred in this play-through though they kinda fixed themselves after some fiddling around, so I didn't report any of that

@BQurious
Copy link
Contributor Author

BQurious commented Aug 12, 2020

It seems attempting to fire the projectile/bayonet from a gun incapable of firing the projectile (no ammo/no UPS) but has a bayonet causes this error instead of reporting the gun as having insufficient ammo/UPS charge or just attacking with bayonet

@BQurious
Copy link
Contributor Author

BQurious commented Aug 12, 2020

By reading the related bug, and the PR mentioned in it, I think this was resolved by #39785
I will check and update by the end of today

@BQurious
Copy link
Contributor Author

Fixed by #39785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant