You can be shot and killed by hallucination NPCs

[Inglonias]

Describe the bug

Hallucinatory NPCs can shoot and kill you.

Steps to reproduce

1. Make a character with Kaluptic Psychosis
2. Wait for them to hallucinate an NPC with a gun.
3. Make that NPC angry.
4. They shoot you and you get hurt.

Here's a savegame you can use. There is an armed hallucination inside the cabin directly to the east. Make them angry and they can shoot you!
Alfred.zip

Expected behavior

I would expect hallucinatory NPCs to NOT be able to shoot me.

Screenshots

Versions and configuration

• OS: Windows
  • OS Version: 10.0 2009
• Game Version: cfc00fa [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [
  Dark Days Ahead [dda],
  Bionic Slots [cbm_slots],
  Disable NPC Needs [no_npc_food],
  No Fungal Growth [no_fungal_growth],
  Bionic Professions [package_bionic_professions],
  No Rail Stations [No_Rail_Stations],
  sees-player, run, crouch, bleed icons, retrodays [sees_player_retro],
  Fewer Soldier Extras [Fewer_Soldiers]
  ]

Additional context

No response

[Inglonias]

This is nonsense and almost makes me want to debug away the psychosis.

[Inglonias]

Oddly enough, we have a pretend_fire() method in ranged.cpp. Either that method is working improperly or is not being called correctly.

[Michael1993]

I don't know how to test this but I think the fix could be this:

if ( source.is_hallucination() ) {
    gun_mode mode = source.get_wielded_item().gun_current_mode();
    source.pretend_fire( source, mode.qty, *mode );
} else {
    source.fire_gun( location );
}

in here: npc_attack.cpp

This piece of code is immediately followed by a debugmsg so seeing if this is indeed the code that gets called instead of the other one should be just loading in the save file and enabling debug messages (npcmove.cpp doesn't have a debugmsg call).

[Inglonias]

I'm at work and can't compile anything right now, but the best way to test this would be to do just that. Compile the project with that code added in, and run it. See if it works as you expect. If it doesn't, make a test procedure and repeat it in the debugger, though playing Cataclysm through a debugger is like walking while neck deep in quicksand. The game slows down to the point of being damn near unplayable.

[Inglonias]

For what it's worth, this looks like the correct answer, but I have a busy day today and can't implement it myself. If nobody does this by tomorrow, and assuming the COVID booster doesn't kick my ass, I'll try it.

[Inglonias]

I don't know how to test this but I think the fix could be this:

if ( source.is_hallucination() ) {
    gun_mode mode = source.get_wielded_item().gun_current_mode();
    source.pretend_fire( source, mode.qty, *mode );
} else {
    source.fire_gun( location );
}

in here: npc_attack.cpp

This piece of code is immediately followed by a debugmsg so seeing if this is indeed the code that gets called instead of the other one should be just loading in the save file and enabling debug messages (npcmove.cpp doesn't have a debugmsg call).

Congratulations sir. You were almost 100% correct. The only incorrect thing in your fix was the if statement you provided was inverted. Otherwise, it works great!