NPC's running through closed doors and being attacked across z-levels.

[Techmind]

Describe the bug

NPC's are broken they get attacked thought z-levels and will run through closed doors.
I also had a similar message with npc being underground (-1 level) and it was attacked by ant from "0-level" i think a few hundred turns before.

Steps to reproduce

Google drive link to save: https://drive.google.com/file/d/19xG0Yq0MfjPzj0h42GWBSnbPiGRJQ7dC/view?usp=sharing
Probably has something to do with latest experimental versions there is couple of bugs:
A) if you open the door and lead ants to nps they will attack them, debug message with "
DEBUG : Z-Level view violation: the ant tried to attack Charlotte Hall.

FUNCTION : bool monster::melee_attack(Creature&, float)
FILE : src/monster.cpp
LINE : 1593
VERSION : 9da956a"

appers and npc disappears.

B) If you don't open the door and wait for a few turns NPCS will run through door without opening it

Expected behavior

Npc opening doors and not disappearing.

Screenshots

Versions and configuration

• OS: Windows
  • OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
• Game Version: 9da956a [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  No Fungal Growth [no_fungal_growth],
  Bionic Professions [package_bionic_professions],
  Magiclysm [magiclysm],
  Graphical Overmap [Graphical_Overmap],
  Graphical Overmap Magiclysm [Graphical_Overmap_Magiclysm],
  Stats Through Kills [stats_through_kills],
  SpeedyDex [speedydex],
  Stats Through Skills [StatsThroughSkills],
  Arcana and Magic Items [Arcana]
  ]

Additional context

No response

[hexagonrecursion]

Confirmed using the save file you attached. Note: I do not have Arcana. The NPCs are hallucinations. This can be confirmed by viewing their @ status window via the cheat menu.

• The two hallucinations run through a door w/o opening it. What should they do? The only alternative is hallucinations being stuck against a closed door which is not any less confusing.
• They trigger a debug assertion when attacked. This is a bug.
• The following is printed to the chat when they disappear:

Otis Burgos triggers a spiked board!
Otis Burgos disappears.
Charlotte Hall triggers a spiked board!
Charlotte Hall disappears.

Might be related: #53243

• OS: Linux
  • OS Version: LSB Version: :core-4.1-amd64:core-4.1-noarch; Distributor ID: Fedora; Description: Fedora release 34 (Thirty Four); Release: 34; Codename: ThirtyFour;
• Game Version: 579f907 [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  No Fungal Growth [no_fungal_growth],
  Bionic Professions [package_bionic_professions],
  Magiclysm [magiclysm],
  Graphical Overmap [Graphical_Overmap],
  Graphical Overmap Magiclysm [Graphical_Overmap_Magiclysm],
  Stats Through Kills [stats_through_kills],
  SpeedyDex [speedydex],
  Stats Through Skills [StatsThroughSkills],
  No name () []
  ]

[Techmind]

Ok, did not know i can halluciante NPCS, then i guess can be considered a "feature".
Through debug message is a bit annoying.

[hexagonrecursion]

I have opened a separate bug for z-level assertions. This issue can be kept for discussion of what can be done about hallucinatory NPCs phasing through doors. As you have demonstrate this can cause player confusion. A possibly less confusing solution is for the NPCs to disappear right before they try to go through a door.

[hexagonrecursion]

Hallucinations in the attached save file still phase through closed doors even after #54307 was merged

• OS: Linux
  • OS Version: LSB Version: :core-4.1-amd64:core-4.1-noarch; Distributor ID: Fedora; Description: Fedora release 34 (Thirty Four); Release: 34; Codename: ThirtyFour;
• Game Version: c8a49e1 [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  No Fungal Growth [no_fungal_growth],
  Bionic Professions [package_bionic_professions],
  Magiclysm [magiclysm],
  Graphical Overmap [Graphical_Overmap],
  Graphical Overmap Magiclysm [Graphical_Overmap_Magiclysm],
  Stats Through Kills [stats_through_kills],
  SpeedyDex [speedydex],
  Stats Through Skills [StatsThroughSkills],
  No name () []
  ]

The z level issue is partially fixed. More here: #54364

[LeahLuong]

@hexagonrecursion Regarding #54307, dseguin commented on Fris0uman''s comment in that thread:

Because if they can't open doors at all they'll stay stuck on the other side instead of following you.

It looks like that behaviour still works:
Not sure if that's the way it's supposed to work, but the door remains closed.

If hallucinations are interacting w/ doors, they are having a physical impact in the game. Having them phase thru seems like the best solution for now.