-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added methods to allow the user to choose Identifier keys for OnUserLogin via plist or Config #156
Conversation
akashvercetti
commented
Nov 10, 2021
•
edited
Loading
edited
- Refactored OnUserLogin to accept identity keys from plist
- Added filters to allow only supported identity keys from plist
- Added setter method for instance config to set identifier keys in case of multi instances
- Added unit tests for new Identity Management
# Conflicts: # CleverTapSDK/CleverTapInstanceConfig.h # CleverTapSDK/CleverTapInstanceConfig.m
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -14,6 +14,7 @@ | |||
@property (nonatomic, assign) BOOL useCustomCleverTapId; | |||
@property (nonatomic, assign) BOOL disableIDFV; | |||
@property (nonatomic, assign) CleverTapLogLevel logLevel; | |||
@property (nonatomic, strong, nullable) NSArray *identityKeys; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
identityKeys
are meant to be nullable?
…rtap-ios-sdk into peter-test-setup # Conflicts: # CleverTapSDKTests/BaseTestCase.m # CleverTapSDKTests/CleverTap+Tests.h
Merge branch 'feature/SDK-394-phone-identity' of https://github.com/CleverTap/clevertap-ios-sdk into peter-test-setup # Conflicts: # CleverTapSDK.xcodeproj/project.pbxproj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM