Add check for whether P(z) is bijective or not #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
reviewed
Jan 24, 2025
src/Atmos.jl
Outdated
| @@ -22,6 +22,8 @@ Linearly interpolate `var1d` from `origin_pressure` to `target_pressure`. | |||
| Note: Values outside of the range are linearly extrapolated | |||
| """ | |||
| function _resample_column!(dest, var1d, origin_pressure, target_pressure) | |||
| !issorted(origin_pressure, lt = !isless) && | |||
There was a problem hiding this comment.
There's many negative in this line and it is a little opaque. Do you need !isless to account for identical values?
ph-kev
force-pushed
the
kp/fixing-leaderboard
branch
4 times, most recently
from
8cb625e to
dab5acb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
=======================================
Coverage 98.17% 98.18%
=======================================
Files 12 12
Lines 1206 1209 +3
=======================================
+ Hits 1184 1187 +3
Misses 22 22 ☔ View full report in Codecov by Sentry. |
ph-kev
force-pushed
the
kp/fixing-leaderboard
branch
from
dab5acb to
c8e8210
Compare
ph-kev
force-pushed
the
kp/fixing-leaderboard
branch
from
c8e8210 to
b5f127c
Compare
|
There is a new function |
Sbozzolo
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check for whether P(z) is bijective or not when resampling columns.