Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deprecated kwarg in docs #80

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

imreddyTeja
Copy link
Contributor

Quick Start docs previously used a deprecated kwarg in the visualize section. The deprecated kwarg, resolution, is swapped for shape. The line no longer throws a warning after the change

Purpose

Closes #77 -- this will automatically close issue 77 on PR merge

To-do

Content

  • Changed line in docs to no longer use deprecated kwarg

  • I have read and checked the items on the review checklist.

Quick Start docs previously used a deprecated kwarg in the
visualize section. The deprecated kwarg, `resolution`, is swapped
for `shape`
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.37%. Comparing base (564c753) to head (d5e8e23).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files          10       10           
  Lines         607      607           
=======================================
  Hits          585      585           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Sbozzolo Sbozzolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@imreddyTeja imreddyTeja merged commit 5b123f7 into main Sep 9, 2024
7 checks passed
@imreddyTeja imreddyTeja deleted the tr/fix-quick-start-docs-deprecated branch September 9, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick Start Docs use Deprecated kwarg
2 participants